| Message ID | 20210819101020.26368-2-krzysztof.kozlowski@canonical.com |
|---|---|
| State | Accepted |
| Commit | 0aeb17d1728257f29131a290f0cc8e281cc7274c |
| Headers | show |
| Series | [1/2] dt-bindings: panel: ili9341: correct indentation | expand |
On Thu, Aug 19, 2021 at 5:12 AM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Use common enum instead of oneOf and correct indentation warning: > realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../devicetree/bindings/sound/realtek,rt1015p.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
On Thu, Aug 19, 2021 at 04:52:38PM -0500, Rob Herring wrote: > On Thu, Aug 19, 2021 at 5:12 AM Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com> wrote: > > > > Use common enum instead of oneOf and correct indentation warning: > > realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation) > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Acked-by: Rob Herring <robh@kernel.org> Acked-by: Tzung-Bi Shih <tzungbi@google.com>
On Thu, Aug 19, 2021 at 12:10:20PM +0200, Krzysztof Kozlowski wrote: > Use common enum instead of oneOf and correct indentation warning: > realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation) For stuff like this where there's no relationship between the things being patched it's probably better to just send a bunch of individual patches rather than a series, it works better with tooling and makes it clear there's no interdependencies or anything. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml b/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml index f31d3c4d0192..fdb7f295ef2d 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt1015p.yaml @@ -15,9 +15,9 @@ description: | properties: compatible: - oneOf: - - const: realtek,rt1015p - - const: realtek,rt1019p + enum: + - realtek,rt1015p + - realtek,rt1019p sdb-gpios: description:
Use common enum instead of oneOf and correct indentation warning: realtek,rt1015p.yaml:18:7: [warning] wrong indentation: expected 4 but found 6 (indentation) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../devicetree/bindings/sound/realtek,rt1015p.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)