| Message ID | 20210820081645.83796-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema | expand |
On Fri, Aug 20, 2021 at 4:17 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Align the name of thermal zone node to dtschema to fix warnings like: > > arch/arm64/boot/dts/allwinner/sun50i-a100-allwinner-perf1.dt.yaml: > thermal-zones: 'cpu-thermal-zone', 'ddr-thermal-zone', 'gpu-thermal-zone' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Acked-by: Chen-Yu Tsai <wens@csie.org>
On 20/08/2021 14:11, Chen-Yu Tsai wrote: > On Fri, Aug 20, 2021 at 4:16 PM Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com> wrote: >> >> Align the name of operating-points node to dtschema to fix warnings like: >> >> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml: >> cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$' >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi >> index b2657201957e..0b6914a165b0 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi >> @@ -2,7 +2,7 @@ >> // Copyright (C) 2020 Chen-Yu Tsai <wens@csie.org> >> >> / { >> - cpu_opp_table: cpu-opp-table { >> + cpu_opp_table: opp-table-0 { > > Maybe we should just reorder the name? Name it "opp-table-cpu" instead. > That way if and when we add one for the GPU, we don't accidentally > clash on the name. Although the schema allows such name, but still the devicetree specification says that name should be generic (representing generic type of a device). Just like there is a "clock-controller" or "nand-controller", there should be generic "opp-table". Best regards, Krzysztof
On Fri, Aug 20, 2021 at 10:16:44AM +0200, Krzysztof Kozlowski wrote: > Align the name of operating-points node to dtschema to fix warnings like: > > arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml: > cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> I already sent those patches a few weeks ago: https://lore.kernel.org/linux-arm-kernel/20210721140424.725744-43-maxime@cerno.tech/ https://lore.kernel.org/linux-arm-kernel/20210721140424.725744-48-maxime@cerno.tech/ https://lore.kernel.org/linux-arm-kernel/20210721140424.725744-50-maxime@cerno.tech/ I sent a v2 last week, and will merge them soon Thanks! Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi index b2657201957e..0b6914a165b0 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi @@ -2,7 +2,7 @@ // Copyright (C) 2020 Chen-Yu Tsai <wens@csie.org> / { - cpu_opp_table: cpu-opp-table { + cpu_opp_table: opp-table-0 { compatible = "operating-points-v2"; opp-shared;
Align the name of operating-points node to dtschema to fix warnings like: arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml: cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$' Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)