| Message ID | 1434987837-24212-5-git-send-email-lee.jones@linaro.org |
|---|---|
| State | New |
| Headers | show |
[Ccing Rob] On 22-06-15, 16:43, Lee Jones wrote: > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/arm/boot/dts/stih407-family.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index f48767e..f57fd83 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -98,6 +98,11 @@ > ranges; > compatible = "simple-bus"; > > + cpufreq { > + compatible = "st,stih407-cpufreq"; > + st,syscfg = <&syscfg_core 0x8e0>; > + }; These virtual nodes aren't allowed in DT and you have added them before the bindings patch :).
On Tue, 23 Jun 2015, Viresh Kumar wrote: > [Ccing Rob] Rob is already Cc'ed. > On 22-06-15, 16:43, Lee Jones wrote: > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/arm/boot/dts/stih407-family.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > index f48767e..f57fd83 100644 > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > @@ -98,6 +98,11 @@ > > ranges; > > compatible = "simple-bus"; > > > > + cpufreq { > > + compatible = "st,stih407-cpufreq"; > > + st,syscfg = <&syscfg_core 0x8e0>; > > + }; > > These virtual nodes aren't allowed in DT and you have added them > before the bindings patch :). This isn't a virtual node, but you bring up a good point. The compatible string should also contain "syscon".
On 23-06-15, 08:10, Lee Jones wrote: > > These virtual nodes aren't allowed in DT and you have added them > > before the bindings patch :). > > This isn't a virtual node, but you bring up a good point. Hmm, wrong choice of words. Sorry.. So, its a node for a virtual device :). The device is CPU and it already has a node for itself. And so such nodes were discouraged earlier by DT maintainers.
diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi index f48767e..f57fd83 100644 --- a/arch/arm/boot/dts/stih407-family.dtsi +++ b/arch/arm/boot/dts/stih407-family.dtsi @@ -98,6 +98,11 @@ ranges; compatible = "simple-bus"; + cpufreq { + compatible = "st,stih407-cpufreq"; + st,syscfg = <&syscfg_core 0x8e0>; + }; + restart { compatible = "st,stih407-restart"; st,syscfg = <&syscfg_sbc_reg>;
Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/stih407-family.dtsi | 5 +++++ 1 file changed, 5 insertions(+)