diff mbox series

selftests/bpf: fix potential unreleased lock

Message ID 20210827074140.118671-1-cyeaa@connect.ust.hk
State New
Headers show
Series selftests/bpf: fix potential unreleased lock | expand

Commit Message

YE Chengfeng Aug. 27, 2021, 7:41 a.m. UTC 
This lock is not released if the program
return at the patched branch.

Cc: cyeaa@connect.ust.hk
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
---
 tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
index ec281b0363b8..86f97681ad89 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt_inherit.c
@@ -195,8 +195,10 @@  static void run_test(int cgroup_fd)
 
 	pthread_mutex_lock(&server_started_mtx);
 	if (CHECK_FAIL(pthread_create(&tid, NULL, server_thread,
-				      (void *)&server_fd)))
+				      (void *)&server_fd))) {
+		pthread_mutex_unlock(&server_started_mtx);
 		goto close_server_fd;
+	}
 	pthread_cond_wait(&server_started, &server_started_mtx);
 	pthread_mutex_unlock(&server_started_mtx);