diff mbox series

[v2,46/52] ARM: dts: cubieboard4: Remove the dumb-vga-dac compatible

Message ID 20210901091852.479202-47-maxime@cerno.tech
State Accepted
Commit 11085c654814d5ff30558df0c918a84fecee349c
Headers show
Series ARM: dts: Last round of DT schema fixes | expand

Commit Message

Maxime Ripard Sept. 1, 2021, 9:18 a.m. UTC 
The dumb-vga-dac and adi,adv7123 compatibles are not supposed to be used
together according to the binding.

Since the corpro gm7123 is a drop-in replacement for the adv7123, let's
remove dumb-vga-dac from our compatible list.

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jernej Škrabec Sept. 5, 2021, 9:12 p.m. UTC | #1 
Dne sreda, 01. september 2021 ob 11:18:46 CEST je Maxime Ripard napisal(a):
> The dumb-vga-dac and adi,adv7123 compatibles are not supposed to be used

> together according to the binding.

> 

> Since the corpro gm7123 is a drop-in replacement for the adv7123, let's

> remove dumb-vga-dac from our compatible list.

> 

> Reviewed-by: Chen-Yu Tsai <wens@csie.org>

> Signed-off-by: Maxime Ripard <maxime@cerno.tech>


Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>


Best regards,
Jernej
Maxime Ripard Sept. 6, 2021, 1:39 p.m. UTC | #2 
On Sun, Sep 05, 2021 at 11:12:27PM +0200, Jernej Škrabec wrote:
> Dne sreda, 01. september 2021 ob 11:18:46 CEST je Maxime Ripard napisal(a):

> > The dumb-vga-dac and adi,adv7123 compatibles are not supposed to be used

> > together according to the binding.

> > 

> > Since the corpro gm7123 is a drop-in replacement for the adv7123, let's

> > remove dumb-vga-dac from our compatible list.

> > 

> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>

> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>

> 

> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>


Applied, thanks
Maxime
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
index 1fe251ea94bc..c8ca8cb7f5c9 100644
--- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
+++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
@@ -87,7 +87,7 @@  vga_con_in: endpoint {
 	};
 
 	vga-dac {
-		compatible = "corpro,gm7123", "adi,adv7123", "dumb-vga-dac";
+		compatible = "corpro,gm7123", "adi,adv7123";
 		vdd-supply = <&reg_dcdc1>;
 
 		ports {