diff mbox series

[v4,05/11] hw/arm/virt: Use object_property_set instead of qdev_prop_set

Message ID 20211001173358.863017-6-jean-philippe@linaro.org
State Superseded
Headers show
Series virtio-iommu: Add ACPI support | expand

Commit Message

Jean-Philippe Brucker Oct. 1, 2021, 5:33 p.m. UTC 
To propagate errors to the caller of the pre_plug callback, use the
object_poperty_set*() functions directly instead of the qdev_prop_set*()
helpers.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

---
 hw/arm/virt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.33.0

Comments

Eric Auger Oct. 5, 2021, 9:27 a.m. UTC | #1 
On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote:
> To propagate errors to the caller of the pre_plug callback, use the

> object_poperty_set*() functions directly instead of the qdev_prop_set*()

> helpers.

>

> Suggested-by: Igor Mammedov <imammedo@redhat.com>

> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

Reviewed-by: Eric Auger <eric.auger@redhat.com>


Eric
> ---

>  hw/arm/virt.c | 5 +++--

>  1 file changed, 3 insertions(+), 2 deletions(-)

>

> diff --git a/hw/arm/virt.c b/hw/arm/virt.c

> index 36f0261ef4..ac307b6030 100644

> --- a/hw/arm/virt.c

> +++ b/hw/arm/virt.c

> @@ -2465,8 +2465,9 @@ static void virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev,

>                                          db_start, db_end,

>                                          VIRTIO_IOMMU_RESV_MEM_T_MSI);

>  

> -        qdev_prop_set_uint32(dev, "len-reserved-regions", 1);

> -        qdev_prop_set_string(dev, "reserved-regions[0]", resv_prop_str);

> +        object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1, errp);

> +        object_property_set_str(OBJECT(dev), "reserved-regions[0]",

> +                                resv_prop_str, errp);

>          g_free(resv_prop_str);

>      }

>  }
Igor Mammedov Oct. 6, 2021, 6:36 a.m. UTC | #2 
On Fri,  1 Oct 2021 18:33:53 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> To propagate errors to the caller of the pre_plug callback, use the

> object_poperty_set*() functions directly instead of the qdev_prop_set*()

> helpers.

> 

> Suggested-by: Igor Mammedov <imammedo@redhat.com>

> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>


Reviewed-by: Igor Mammedov <imammedo@redhat.com>


> ---

>  hw/arm/virt.c | 5 +++--

>  1 file changed, 3 insertions(+), 2 deletions(-)

> 

> diff --git a/hw/arm/virt.c b/hw/arm/virt.c

> index 36f0261ef4..ac307b6030 100644

> --- a/hw/arm/virt.c

> +++ b/hw/arm/virt.c

> @@ -2465,8 +2465,9 @@ static void virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev,

>                                          db_start, db_end,

>                                          VIRTIO_IOMMU_RESV_MEM_T_MSI);

>  

> -        qdev_prop_set_uint32(dev, "len-reserved-regions", 1);

> -        qdev_prop_set_string(dev, "reserved-regions[0]", resv_prop_str);

> +        object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1, errp);

> +        object_property_set_str(OBJECT(dev), "reserved-regions[0]",

> +                                resv_prop_str, errp);

>          g_free(resv_prop_str);

>      }

>  }
diff mbox series

Patch

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 36f0261ef4..ac307b6030 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2465,8 +2465,9 @@  static void virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev,
                                         db_start, db_end,
                                         VIRTIO_IOMMU_RESV_MEM_T_MSI);
 
-        qdev_prop_set_uint32(dev, "len-reserved-regions", 1);
-        qdev_prop_set_string(dev, "reserved-regions[0]", resv_prop_str);
+        object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1, errp);
+        object_property_set_str(OBJECT(dev), "reserved-regions[0]",
+                                resv_prop_str, errp);
         g_free(resv_prop_str);
     }
 }