diff mbox series

[v4,08/11] tests/acpi: allow updates of VIOT expected data files

Message ID 20211001173358.863017-9-jean-philippe@linaro.org
State Superseded
Headers show
Series virtio-iommu: Add ACPI support | expand

Commit Message

Jean-Philippe Brucker Oct. 1, 2021, 5:33 p.m. UTC 
Create empty data files and allow updates for the upcoming VIOT tests.

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

---
 tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
 tests/data/acpi/q35/DSDT.viot               | 0
 tests/data/acpi/q35/VIOT.viot               | 0
 tests/data/acpi/virt/VIOT                   | 0
 4 files changed, 3 insertions(+)
 create mode 100644 tests/data/acpi/q35/DSDT.viot
 create mode 100644 tests/data/acpi/q35/VIOT.viot
 create mode 100644 tests/data/acpi/virt/VIOT

diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/q35/VIOT.viot b/tests/data/acpi/q35/VIOT.viot
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/data/acpi/virt/VIOT b/tests/data/acpi/virt/VIOT
new file mode 100644
index 0000000000..e69de29bb2
-- 
2.33.0

Comments

Igor Mammedov Oct. 6, 2021, 8:12 a.m. UTC | #1 
On Fri,  1 Oct 2021 18:33:56 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> Create empty data files and allow updates for the upcoming VIOT tests.

> 

> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

> ---

>  tests/qtest/bios-tables-test-allowed-diff.h | 3 +++

>  tests/data/acpi/q35/DSDT.viot               | 0


does default tests/data/acpi/q35/DSDT differs from
DSDT.viot?

>  tests/data/acpi/q35/VIOT.viot               | 0

>  tests/data/acpi/virt/VIOT                   | 0

>  4 files changed, 3 insertions(+)

>  create mode 100644 tests/data/acpi/q35/DSDT.viot

>  create mode 100644 tests/data/acpi/q35/VIOT.viot

>  create mode 100644 tests/data/acpi/virt/VIOT

> 

> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h

> index dfb8523c8b..29b5b1eabc 100644

> --- a/tests/qtest/bios-tables-test-allowed-diff.h

> +++ b/tests/qtest/bios-tables-test-allowed-diff.h

> @@ -1 +1,4 @@

>  /* List of comma-separated changed AML files to ignore */

> +"tests/data/acpi/virt/VIOT",

> +"tests/data/acpi/q35/DSDT.viot",

> +"tests/data/acpi/q35/VIOT.viot",

> diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot

> new file mode 100644

> index 0000000000..e69de29bb2

> diff --git a/tests/data/acpi/q35/VIOT.viot b/tests/data/acpi/q35/VIOT.viot

> new file mode 100644

> index 0000000000..e69de29bb2

> diff --git a/tests/data/acpi/virt/VIOT b/tests/data/acpi/virt/VIOT

> new file mode 100644

> index 0000000000..e69de29bb2
Jean-Philippe Brucker Oct. 8, 2021, 3:26 p.m. UTC | #2 
On Wed, Oct 06, 2021 at 10:12:15AM +0200, Igor Mammedov wrote:
> On Fri,  1 Oct 2021 18:33:56 +0100

> Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> 

> > Create empty data files and allow updates for the upcoming VIOT tests.

> > 

> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

> > ---

> >  tests/qtest/bios-tables-test-allowed-diff.h | 3 +++

> >  tests/data/acpi/q35/DSDT.viot               | 0

> 

> does default tests/data/acpi/q35/DSDT differs from

> DSDT.viot?


Yes the VIOT test has one more PCI device (virtio-iommu) and PXB devices,
so there are additional descriptors in the DSDT

Thanks,
Jean

> 

> >  tests/data/acpi/q35/VIOT.viot               | 0

> >  tests/data/acpi/virt/VIOT                   | 0

> >  4 files changed, 3 insertions(+)

> >  create mode 100644 tests/data/acpi/q35/DSDT.viot

> >  create mode 100644 tests/data/acpi/q35/VIOT.viot

> >  create mode 100644 tests/data/acpi/virt/VIOT

> > 

> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h

> > index dfb8523c8b..29b5b1eabc 100644

> > --- a/tests/qtest/bios-tables-test-allowed-diff.h

> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h

> > @@ -1 +1,4 @@

> >  /* List of comma-separated changed AML files to ignore */

> > +"tests/data/acpi/virt/VIOT",

> > +"tests/data/acpi/q35/DSDT.viot",

> > +"tests/data/acpi/q35/VIOT.viot",

> > diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot

> > new file mode 100644

> > index 0000000000..e69de29bb2

> > diff --git a/tests/data/acpi/q35/VIOT.viot b/tests/data/acpi/q35/VIOT.viot

> > new file mode 100644

> > index 0000000000..e69de29bb2

> > diff --git a/tests/data/acpi/virt/VIOT b/tests/data/acpi/virt/VIOT

> > new file mode 100644

> > index 0000000000..e69de29bb2

>
Igor Mammedov Oct. 11, 2021, 3:55 p.m. UTC | #3 
On Fri, 8 Oct 2021 16:26:22 +0100
Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> On Wed, Oct 06, 2021 at 10:12:15AM +0200, Igor Mammedov wrote:

> > On Fri,  1 Oct 2021 18:33:56 +0100

> > Jean-Philippe Brucker <jean-philippe@linaro.org> wrote:

> >   

> > > Create empty data files and allow updates for the upcoming VIOT tests.

> > > 

> > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

> > > ---

> > >  tests/qtest/bios-tables-test-allowed-diff.h | 3 +++

> > >  tests/data/acpi/q35/DSDT.viot               | 0  

> > 

> > does default tests/data/acpi/q35/DSDT differs from

> > DSDT.viot?  

> 

> Yes the VIOT test has one more PCI device (virtio-iommu) and PXB devices,

> so there are additional descriptors in the DSDT



also see tests/qtest/bios-tables-test.c step 6
(---include diff--- part)

> 

> Thanks,

> Jean

> 

> >   

> > >  tests/data/acpi/q35/VIOT.viot               | 0

> > >  tests/data/acpi/virt/VIOT                   | 0

> > >  4 files changed, 3 insertions(+)

> > >  create mode 100644 tests/data/acpi/q35/DSDT.viot

> > >  create mode 100644 tests/data/acpi/q35/VIOT.viot

> > >  create mode 100644 tests/data/acpi/virt/VIOT

> > > 

> > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h

> > > index dfb8523c8b..29b5b1eabc 100644

> > > --- a/tests/qtest/bios-tables-test-allowed-diff.h

> > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h

> > > @@ -1 +1,4 @@

> > >  /* List of comma-separated changed AML files to ignore */

> > > +"tests/data/acpi/virt/VIOT",

> > > +"tests/data/acpi/q35/DSDT.viot",

> > > +"tests/data/acpi/q35/VIOT.viot",

> > > diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot

> > > new file mode 100644

> > > index 0000000000..e69de29bb2

> > > diff --git a/tests/data/acpi/q35/VIOT.viot b/tests/data/acpi/q35/VIOT.viot

> > > new file mode 100644

> > > index 0000000000..e69de29bb2

> > > diff --git a/tests/data/acpi/virt/VIOT b/tests/data/acpi/virt/VIOT

> > > new file mode 100644

> > > index 0000000000..e69de29bb2  

> >   

>
diff mbox series

Patch

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..29b5b1eabc 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,4 @@ 
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/virt/VIOT",
+"tests/data/acpi/q35/DSDT.viot",
+"tests/data/acpi/q35/VIOT.viot",