| Message ID | 20211221004246.213203-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | video: fbdev: mb862xx: remove redundant assignment to pointer ptr | expand |
On Tue, Dec 21, 2021 at 3:01 AM Colin Ian King <colin.i.king@gmail.com> wrote: > The pointer ptr is being assigned a value that is never read. The > pointer is being re-assigned later in a loop. The assignment is > redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c index d40b806461ca..61aed7fc0b8d 100644 --- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c +++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c @@ -132,7 +132,7 @@ static void mb86290fb_imageblit8(u32 *cmd, u16 step, u16 dx, u16 dy, cmd[2] = (height << 16) | width; i = 0; - line = ptr = image->data; + line = image->data; bytes = image->width; while (i < height) {
The pointer ptr is being assigned a value that is never read. The pointer is being re-assigned later in a loop. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)