| Message ID | 20211227065100.20873-1-pavel.hofman@ivitera.com |
|---|---|
| State | New |
| Headers | show |
| Series | usb: gadget: u_audio: Subdevice 0 for capture ctls | expand |
On Mon, Dec 27, 2021 at 07:51:00AM +0100, Pavel Hofman wrote: > Both capture and playback alsa devices use subdevice 0. Yet capture-side > ctls are defined for subdevice 1. The patch sets subdevice 0 for them. > > Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com> > --- > drivers/usb/gadget/function/u_audio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c > index c46400be5464..4f6c0049c534 100644 > --- a/drivers/usb/gadget/function/u_audio.c > +++ b/drivers/usb/gadget/function/u_audio.c > @@ -1145,7 +1145,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name, > } > > kctl->id.device = pcm->device; > - kctl->id.subdevice = i; > + kctl->id.subdevice = 0; > > err = snd_ctl_add(card, kctl); > if (err < 0) > @@ -1168,7 +1168,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name, > } > > kctl->id.device = pcm->device; > - kctl->id.subdevice = i; > + kctl->id.subdevice = 0; > > > kctl->tlv.c = u_audio_volume_tlv; > -- > 2.25.1 > Does this fix a specific bug/issue? If so, what commit does this fix? thanks, greg k-h
diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index c46400be5464..4f6c0049c534 100644 --- a/drivers/usb/gadget/function/u_audio.c +++ b/drivers/usb/gadget/function/u_audio.c @@ -1145,7 +1145,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name, } kctl->id.device = pcm->device; - kctl->id.subdevice = i; + kctl->id.subdevice = 0; err = snd_ctl_add(card, kctl); if (err < 0) @@ -1168,7 +1168,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name, } kctl->id.device = pcm->device; - kctl->id.subdevice = i; + kctl->id.subdevice = 0; kctl->tlv.c = u_audio_volume_tlv;
Both capture and playback alsa devices use subdevice 0. Yet capture-side ctls are defined for subdevice 1. The patch sets subdevice 0 for them. Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com> --- drivers/usb/gadget/function/u_audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)