| Message ID | 1440942866-23802-6-git-send-email-christoffer.dall@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 30/08/15 14:54, Christoffer Dall wrote: > We currently initialize the SGIs to be enabled in the VGIC code, but we > use the VGIC_NR_PPIS define for this purpose, instead of the the more > natural VGIC_NR_SGIS. Change this slightly confusing use of the > defines. > > Note: This should have no functional change, as both names are defined > to the number 16. > > Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> Ah, that's a confusing one, well spotted. Acked-by: Marc Zyngier <marc.zyngier@arm.com> M.
On 08/30/2015 03:54 PM, Christoffer Dall wrote: > We currently initialize the SGIs to be enabled in the VGIC code, but we > use the VGIC_NR_PPIS define for this purpose, instead of the the more s/the// Eric > natural VGIC_NR_SGIS. Change this slightly confusing use of the > defines. > > Note: This should have no functional change, as both names are defined > to the number 16. > > Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> > --- > virt/kvm/arm/vgic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c > index 0ba92d3..8299c24 100644 > --- a/virt/kvm/arm/vgic.c > +++ b/virt/kvm/arm/vgic.c > @@ -2099,7 +2099,7 @@ int vgic_init(struct kvm *kvm) > } > > for (i = 0; i < dist->nr_irqs; i++) { > - if (i < VGIC_NR_PPIS) > + if (i < VGIC_NR_SGIS) > vgic_bitmap_set_irq_val(&dist->irq_enabled, > vcpu->vcpu_id, i, 1); > if (i < VGIC_NR_PRIVATE_IRQS) >
diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 0ba92d3..8299c24 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm/vgic.c @@ -2099,7 +2099,7 @@ int vgic_init(struct kvm *kvm) } for (i = 0; i < dist->nr_irqs; i++) { - if (i < VGIC_NR_PPIS) + if (i < VGIC_NR_SGIS) vgic_bitmap_set_irq_val(&dist->irq_enabled, vcpu->vcpu_id, i, 1); if (i < VGIC_NR_PRIVATE_IRQS)
We currently initialize the SGIs to be enabled in the VGIC code, but we use the VGIC_NR_PPIS define for this purpose, instead of the the more natural VGIC_NR_SGIS. Change this slightly confusing use of the defines. Note: This should have no functional change, as both names are defined to the number 16. Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> --- virt/kvm/arm/vgic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)