diff mbox

[v2,4/8] rockchip: Turn off CONFIG_SPL_LED_SUPPORT for firefly

Message ID 1440955874-25809-5-git-send-email-sjoerd.simons@collabora.co.uk
State New
Headers show

Commit Message

Sjoerd Simons Aug. 30, 2015, 5:31 p.m. UTC
With LED support enabled the SPL easily goes over the size limit (e.g.
with both Debians gcc 4.9 and 5.2 cross-compilers). Turn off LED support
in the SPL to reduce the size just enough for those compilers.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

Changes in v2:
- Also drop CONFIG_SPL_LED from the firefly defconfig

 configs/firefly-rk3288_defconfig | 1 -
 include/configs/firefly-rk3288.h | 1 -
 2 files changed, 2 deletions(-)

Comments

Simon Glass Aug. 30, 2015, 10:45 p.m. UTC | #1
On 30 August 2015 at 11:31, Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote:
> With LED support enabled the SPL easily goes over the size limit (e.g.
> with both Debians gcc 4.9 and 5.2 cross-compilers). Turn off LED support
> in the SPL to reduce the size just enough for those compilers.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>
> ---
>
> Changes in v2:
> - Also drop CONFIG_SPL_LED from the firefly defconfig
>
>  configs/firefly-rk3288_defconfig | 1 -
>  include/configs/firefly-rk3288.h | 1 -
>  2 files changed, 2 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
index 4c41ae3..03fe715 100644
--- a/configs/firefly-rk3288_defconfig
+++ b/configs/firefly-rk3288_defconfig
@@ -17,7 +17,6 @@  CONFIG_REGMAP=y
 CONFIG_SYSCON=y
 CONFIG_RESET=y
 CONFIG_LED=y
-CONFIG_SPL_LED=y
 CONFIG_LED_GPIO=y
 CONFIG_DEBUG_UART=y
 CONFIG_DEBUG_UART_BASE=0xff690000
diff --git a/include/configs/firefly-rk3288.h b/include/configs/firefly-rk3288.h
index 82e7c9c..a82adc8 100644
--- a/include/configs/firefly-rk3288.h
+++ b/include/configs/firefly-rk3288.h
@@ -10,6 +10,5 @@ 
 #include <configs/rk3288_common.h>
 
 #define CONFIG_SPL_MMC_SUPPORT
-#define CONFIG_SPL_LED_SUPPORT
 
 #endif