| Message ID | 1641749107-31979-5-git-send-email-quic_mkshah@quicinc.com |
|---|---|
| State | Accepted |
| Commit | 6574702b0d394d2acc9ff808c4a79df8b9999173 |
| Headers | show |
| Series | Add APSS RSC to Cluster power domain | expand |
On Sun, 9 Jan 2022 at 18:25, Maulik Shah <quic_mkshah@quicinc.com> wrote: > > This change updates/corrects below cpuidle parameters > > 1. entry-latency, exit-latency and residency for various idle states. > 2. arm,psci-suspend-param which is same for CLUSTER_SLEEP_0/1 states. > 3. Add CLUSTER_SLEEP_1 in CLUSTER_PD. > > Cc: devicetree@vger.kernel.org > Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI") > Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 10c25ad..5e329f8 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -203,9 +203,9 @@ > compatible = "arm,idle-state"; > idle-state-name = "silver-rail-power-collapse"; > arm,psci-suspend-param = <0x40000004>; > - entry-latency-us = <274>; > - exit-latency-us = <480>; > - min-residency-us = <3934>; > + entry-latency-us = <800>; > + exit-latency-us = <750>; > + min-residency-us = <4090>; > local-timer-stop; > }; > > @@ -213,9 +213,9 @@ > compatible = "arm,idle-state"; > idle-state-name = "gold-rail-power-collapse"; > arm,psci-suspend-param = <0x40000004>; > - entry-latency-us = <327>; > - exit-latency-us = <1502>; > - min-residency-us = <4488>; > + entry-latency-us = <600>; > + exit-latency-us = <1550>; > + min-residency-us = <4791>; > local-timer-stop; > }; > }; > @@ -224,10 +224,10 @@ > CLUSTER_SLEEP_0: cluster-sleep-0 { > compatible = "domain-idle-state"; > idle-state-name = "cluster-l3-off"; > - arm,psci-suspend-param = <0x4100c344>; > - entry-latency-us = <584>; > - exit-latency-us = <2332>; > - min-residency-us = <6118>; > + arm,psci-suspend-param = <0x41000044>; > + entry-latency-us = <1050>; > + exit-latency-us = <2500>; > + min-residency-us = <5309>; > local-timer-stop; > }; > > @@ -235,9 +235,9 @@ > compatible = "domain-idle-state"; > idle-state-name = "cluster-power-collapse"; > arm,psci-suspend-param = <0x4100c344>; > - entry-latency-us = <2893>; > - exit-latency-us = <4023>; > - min-residency-us = <9987>; > + entry-latency-us = <2700>; > + exit-latency-us = <3500>; > + min-residency-us = <13959>; > local-timer-stop; > }; > }; > @@ -315,7 +315,7 @@ > > CLUSTER_PD: cpu-cluster0 { > #power-domain-cells = <0>; > - domain-idle-states = <&CLUSTER_SLEEP_0>; > + domain-idle-states = <&CLUSTER_SLEEP_0 &CLUSTER_SLEEP_1>; Should this be like the below instead? <&CLUSTER_SLEEP_0>, <&CLUSTER_SLEEP_1>; > }; > }; > > -- > 2.7.4 > Other than the above, feel free to add: Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe
Hi, On 1/14/2022 6:00 PM, Ulf Hansson wrote: > >> @@ -315,7 +315,7 @@ >> >> CLUSTER_PD: cpu-cluster0 { >> #power-domain-cells = <0>; >> - domain-idle-states = <&CLUSTER_SLEEP_0>; >> + domain-idle-states = <&CLUSTER_SLEEP_0 &CLUSTER_SLEEP_1>; > Should this be like the below instead? > > <&CLUSTER_SLEEP_0>, <&CLUSTER_SLEEP_1>; Thanks for catching this. Will correct in v2. Thanks, Maulik
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 10c25ad..5e329f8 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -203,9 +203,9 @@ compatible = "arm,idle-state"; idle-state-name = "silver-rail-power-collapse"; arm,psci-suspend-param = <0x40000004>; - entry-latency-us = <274>; - exit-latency-us = <480>; - min-residency-us = <3934>; + entry-latency-us = <800>; + exit-latency-us = <750>; + min-residency-us = <4090>; local-timer-stop; }; @@ -213,9 +213,9 @@ compatible = "arm,idle-state"; idle-state-name = "gold-rail-power-collapse"; arm,psci-suspend-param = <0x40000004>; - entry-latency-us = <327>; - exit-latency-us = <1502>; - min-residency-us = <4488>; + entry-latency-us = <600>; + exit-latency-us = <1550>; + min-residency-us = <4791>; local-timer-stop; }; }; @@ -224,10 +224,10 @@ CLUSTER_SLEEP_0: cluster-sleep-0 { compatible = "domain-idle-state"; idle-state-name = "cluster-l3-off"; - arm,psci-suspend-param = <0x4100c344>; - entry-latency-us = <584>; - exit-latency-us = <2332>; - min-residency-us = <6118>; + arm,psci-suspend-param = <0x41000044>; + entry-latency-us = <1050>; + exit-latency-us = <2500>; + min-residency-us = <5309>; local-timer-stop; }; @@ -235,9 +235,9 @@ compatible = "domain-idle-state"; idle-state-name = "cluster-power-collapse"; arm,psci-suspend-param = <0x4100c344>; - entry-latency-us = <2893>; - exit-latency-us = <4023>; - min-residency-us = <9987>; + entry-latency-us = <2700>; + exit-latency-us = <3500>; + min-residency-us = <13959>; local-timer-stop; }; }; @@ -315,7 +315,7 @@ CLUSTER_PD: cpu-cluster0 { #power-domain-cells = <0>; - domain-idle-states = <&CLUSTER_SLEEP_0>; + domain-idle-states = <&CLUSTER_SLEEP_0 &CLUSTER_SLEEP_1>; }; };
This change updates/corrects below cpuidle parameters 1. entry-latency, exit-latency and residency for various idle states. 2. arm,psci-suspend-param which is same for CLUSTER_SLEEP_0/1 states. 3. Add CLUSTER_SLEEP_1 in CLUSTER_PD. Cc: devicetree@vger.kernel.org Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI") Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com> --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-)