| Message ID | 20220121210618.3482550-3-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Commit | d5c5e78f217172e87d8fb2c3418dd8b58b4adfcb |
| Headers | show |
| Series | drm/msm/dpu: simplify RM code | expand |
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote: > Add missing calls to dpu_hw_dspp_destroy() to free resources allocated > for DSPP hardware blocks. > > Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > index b5b1ea1e4de6..63ed0d7df848 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > @@ -35,6 +35,14 @@ int dpu_rm_destroy(struct dpu_rm *rm) > { > int i; > > + for (i = 0; i < ARRAY_SIZE(rm->dspp_blks); i++) { > + struct dpu_hw_dspp *hw; > + > + if (rm->dspp_blks[i]) { > + hw = to_dpu_hw_dspp(rm->dspp_blks[i]); > + dpu_hw_dspp_destroy(hw); > + } > + } > for (i = 0; i < ARRAY_SIZE(rm->pingpong_blks); i++) { > struct dpu_hw_pingpong *hw; >
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index b5b1ea1e4de6..63ed0d7df848 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c @@ -35,6 +35,14 @@ int dpu_rm_destroy(struct dpu_rm *rm) { int i; + for (i = 0; i < ARRAY_SIZE(rm->dspp_blks); i++) { + struct dpu_hw_dspp *hw; + + if (rm->dspp_blks[i]) { + hw = to_dpu_hw_dspp(rm->dspp_blks[i]); + dpu_hw_dspp_destroy(hw); + } + } for (i = 0; i < ARRAY_SIZE(rm->pingpong_blks); i++) { struct dpu_hw_pingpong *hw;
Add missing calls to dpu_hw_dspp_destroy() to free resources allocated for DSPP hardware blocks. Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 8 ++++++++ 1 file changed, 8 insertions(+)