| Message ID | 1442850433-5903-8-git-send-email-sudeep.holla@arm.com |
|---|---|
| State | New |
| Headers | show |
The $SUBJECT is not correct. > The driver handles wakeup irq correctly using irq_set_irq_wake. There's > no need to use IRQF_NO_SUSPEND while registering the interrupt. > > This patch removes the use of IRQF_NO_SUSPEND flag. > > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/mfd/qcom_rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ... code is fine though: Acked-by: Lee Jones <lee.jones@linaro.org> Please re-submit with the subject line fixed. > diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c > index 6afc9fabd94c..207a3bd68559 100644 > --- a/drivers/mfd/qcom_rpm.c > +++ b/drivers/mfd/qcom_rpm.c > @@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev) > ret = devm_request_irq(&pdev->dev, > irq_ack, > qcom_rpm_ack_interrupt, > - IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND, > + IRQF_TRIGGER_RISING, > "qcom_rpm_ack", > rpm); > if (ret) {
On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote: > The $SUBJECT is not correct. > >> The driver handles wakeup irq correctly using irq_set_irq_wake. There's >> no need to use IRQF_NO_SUSPEND while registering the interrupt. >> >> This patch removes the use of IRQF_NO_SUSPEND flag. >> >> Cc: Samuel Ortiz <sameo@linux.intel.com> >> Cc: Lee Jones <lee.jones@linaro.org> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> drivers/mfd/qcom_rpm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > ... code is fine though: > > Acked-by: Lee Jones <lee.jones@linaro.org> > > Please re-submit with the subject line fixed. What's wrong with the subject? Thanks.
Hi Lee, On 22/09/15 00:21, Lee Jones wrote: > The $SUBJECT is not correct. > Any suggestions ? Most of this series I have used "remove misuse..." But this driver was doing things correctly, just that it left this flag as is. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Mon, 21 Sep 2015, Dmitry Torokhov wrote: > On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote: > > The $SUBJECT is not correct. > > > >> The driver handles wakeup irq correctly using irq_set_irq_wake. There's > >> no need to use IRQF_NO_SUSPEND while registering the interrupt. > >> > >> This patch removes the use of IRQF_NO_SUSPEND flag. > >> > >> Cc: Samuel Ortiz <sameo@linux.intel.com> > >> Cc: Lee Jones <lee.jones@linaro.org> > >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > >> --- > >> drivers/mfd/qcom_rpm.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > ... code is fine though: > > > > Acked-by: Lee Jones <lee.jones@linaro.org> > > > > Please re-submit with the subject line fixed. > > What's wrong with the subject? This patch has nothing to do with Input and the first word of the explanatory sentence should start with an uppercase character.
On 22/09/15 22:08, Lee Jones wrote: > On Mon, 21 Sep 2015, Dmitry Torokhov wrote: > >> On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote: >>> The $SUBJECT is not correct. >>> >>>> The driver handles wakeup irq correctly using irq_set_irq_wake. There's >>>> no need to use IRQF_NO_SUSPEND while registering the interrupt. >>>> >>>> This patch removes the use of IRQF_NO_SUSPEND flag. >>>> >>>> Cc: Samuel Ortiz <sameo@linux.intel.com> >>>> Cc: Lee Jones <lee.jones@linaro.org> >>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >>>> --- >>>> drivers/mfd/qcom_rpm.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> ... code is fine though: >>> >>> Acked-by: Lee Jones <lee.jones@linaro.org> >>> >>> Please re-submit with the subject line fixed. >> >> What's wrong with the subject? > > This patch has nothing to do with Input and the first word of the > explanatory sentence should start with an uppercase character. > Ah my stupid mistake, I didn't realize it. Sorry for the noise, will fix it and send. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c index 6afc9fabd94c..207a3bd68559 100644 --- a/drivers/mfd/qcom_rpm.c +++ b/drivers/mfd/qcom_rpm.c @@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq_ack, qcom_rpm_ack_interrupt, - IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND, + IRQF_TRIGGER_RISING, "qcom_rpm_ack", rpm); if (ret) {
The driver handles wakeup irq correctly using irq_set_irq_wake. There's no need to use IRQF_NO_SUSPEND while registering the interrupt. This patch removes the use of IRQF_NO_SUSPEND flag. Cc: Samuel Ortiz <sameo@linux.intel.com> Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/mfd/qcom_rpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)