diff mbox series

Bluetooth: 6lowpan: No need to clear memory twice

Message ID 2f67f1c5ed7de38b78a296c798f3d4afe9e3bd63.1644787831.git.christophe.jaillet@wanadoo.fr
State Accepted
Commit 8d8e748eed56d669ec4386dcdfea406bda908f2a
Headers show
Series Bluetooth: 6lowpan: No need to clear memory twice | expand

Commit Message

Christophe JAILLET Feb. 13, 2022, 9:30 p.m. UTC
'peer_addr' is a structure embedded in 'struct lowpan_peer'. So there is no
need to explicitly call memset(0) on it. It is already zeroed by kzalloc()
when 'peer' is allocated.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 net/bluetooth/6lowpan.c | 1 -
 1 file changed, 1 deletion(-)

Comments

bluez.test.bot@gmail.com Feb. 13, 2022, 10 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=613897

---Test result---

Test Summary:
CheckPatch                    PASS      1.64 seconds
GitLint                       PASS      1.05 seconds
SubjectPrefix                 PASS      0.83 seconds
BuildKernel                   PASS      34.58 seconds
BuildKernel32                 PASS      30.57 seconds
Incremental Build with patchesPASS      41.25 seconds
TestRunner: Setup             PASS      541.75 seconds
TestRunner: l2cap-tester      PASS      15.24 seconds
TestRunner: bnep-tester       PASS      7.02 seconds
TestRunner: mgmt-tester       PASS      115.93 seconds
TestRunner: rfcomm-tester     PASS      8.80 seconds
TestRunner: sco-tester        PASS      8.81 seconds
TestRunner: smp-tester        PASS      8.72 seconds
TestRunner: userchan-tester   PASS      7.27 seconds



---
Regards,
Linux Bluetooth
Marcel Holtmann Feb. 14, 2022, 2:18 p.m. UTC | #2
Hi Christophe,

> 'peer_addr' is a structure embedded in 'struct lowpan_peer'. So there is no
> need to explicitly call memset(0) on it. It is already zeroed by kzalloc()
> when 'peer' is allocated.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> net/bluetooth/6lowpan.c | 1 -
> 1 file changed, 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel
diff mbox series

Patch

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 133d7ea063fb..8e8c07541153 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -641,7 +641,6 @@  static struct l2cap_chan *add_peer_chan(struct l2cap_chan *chan,
 		return NULL;
 
 	peer->chan = chan;
-	memset(&peer->peer_addr, 0, sizeof(struct in6_addr));
 
 	baswap((void *)peer->lladdr, &chan->dst);