| Message ID | 20220302222448.1373765-1-djrscally@gmail.com |
|---|---|
| State | Accepted |
| Commit | 3d1e4228c9dd5c945a5cb621749f358766ee5777 |
| Headers | show |
| Series | [v2] media: i2c: Fix pixel array positions in ov8865 | expand |
diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c index cfc726e0ed1e..b8f4f0d3e33d 100644 --- a/drivers/media/i2c/ov8865.c +++ b/drivers/media/i2c/ov8865.c @@ -457,8 +457,8 @@ #define OV8865_NATIVE_WIDTH 3296 #define OV8865_NATIVE_HEIGHT 2528 -#define OV8865_ACTIVE_START_TOP 32 -#define OV8865_ACTIVE_START_LEFT 80 +#define OV8865_ACTIVE_START_LEFT 16 +#define OV8865_ACTIVE_START_TOP 40 #define OV8865_ACTIVE_WIDTH 3264 #define OV8865_ACTIVE_HEIGHT 2448
The ov8865's datasheet gives the pixel array as 3296x2528, and the active portion as the centre 3264x2448. This makes for a top offset of 40 and a left offset of 16, not 32 and 80. Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865") Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> Signed-off-by: Daniel Scally <djrscally@gmail.com> --- Changes in v2: - Swapped the ordering of the lines so the left offset is first (Paul) drivers/media/i2c/ov8865.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)