| Message ID | 20220309140552.8065-1-srinivas.kandagatla@linaro.org |
|---|---|
| State | Accepted |
| Commit | 31ef579d433a6bcd6b942edea372040298295acf |
| Headers | show |
| Series | [v2] ASoC: qcom: fix Kconfig for SC7280 | expand |
On Wed, 9 Mar 2022 14:05:52 +0000, Srinivas Kandagatla wrote: > select would force the symbol to value without checking the dependencies. > In this case selecting TX and RX MACROs directly without checking its > dependency on COMMON_CLK would break builds on platform which do no > set COMMON_CLK. > ex: > WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO > Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMMON_CLK [=n] > Selected by [m]: > - SND_SOC_SC7280 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && > SND_SOC_QCOM [=m] && I2C [=y] && SOUNDWIRE [=m] > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: qcom: fix Kconfig for SC7280 commit: 31ef579d433a6bcd6b942edea372040298295acf All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 82f5eafb2f6c..28d0dfb4033c 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -195,8 +195,8 @@ config SND_SOC_SC7280 select SND_SOC_MAX98357A select SND_SOC_WCD938X_SDW select SND_SOC_LPASS_MACRO_COMMON - select SND_SOC_LPASS_RX_MACRO - select SND_SOC_LPASS_TX_MACRO + imply SND_SOC_LPASS_RX_MACRO + imply SND_SOC_LPASS_TX_MACRO help Add support for audio on Qualcomm Technologies Inc. SC7280 SoC-based systems.
select would force the symbol to value without checking the dependencies. In this case selecting TX and RX MACROs directly without checking its dependency on COMMON_CLK would break builds on platform which do no set COMMON_CLK. ex: WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMMON_CLK [=n] Selected by [m]: - SND_SOC_SC7280 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_QCOM [=m] && I2C [=y] && SOUNDWIRE [=m] move select to imply which should enforce symbol to be set to 'n' if any dependencies are not resolved. Fixes: 57350bd41c3a ("ASoC: qcom: SC7280: Add machine driver") Reported-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- Changes since v1: - rebased on sound-next sound/soc/qcom/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)