diff mbox series

[RESEND,v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms

Message ID 1647937864-25661-1-git-send-email-quic_saluvala@quicinc.com
State Superseded
Headers show
Series [RESEND,v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms | expand

Commit Message

Sai Teja Aluvala March 22, 2022, 8:31 a.m. UTC
Add IO regulator handler in SC7280 CRD based platforms.
As IO regulator varies in different SC7280 platforms
updating this handler in individual platform bluetooth node.

Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
---
v3: Updated commit text to reflect the change
v2: updated reviewer comments.
v1: intial patch
---
---
 arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

bluez.test.bot@gmail.com March 22, 2022, 9:01 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=625392

---Test result---

Test Summary:
CheckPatch                    PASS      1.59 seconds
GitLint                       FAIL      0.97 seconds
SubjectPrefix                 FAIL      0.87 seconds
BuildKernel                   PASS      31.08 seconds
BuildKernel32                 PASS      26.31 seconds
Incremental Build with patchesPASS      37.21 seconds
TestRunner: Setup             PASS      483.06 seconds
TestRunner: l2cap-tester      PASS      15.60 seconds
TestRunner: bnep-tester       PASS      6.21 seconds
TestRunner: mgmt-tester       PASS      100.79 seconds
TestRunner: rfcomm-tester     PASS      7.91 seconds
TestRunner: sco-tester        PASS      7.64 seconds
TestRunner: smp-tester        PASS      7.68 seconds
TestRunner: userchan-tester   PASS      6.41 seconds

Details
##############################
Test: GitLint - FAIL - 0.97 seconds
Run gitlint with rule in .gitlint
[RESEND,v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms
1: T1 Title exceeds max length (86>80): "[RESEND,v3] arm64: dts: qcom: sc7280: Add IO regulator handler in SC7280 CRD platforms"


##############################
Test: SubjectPrefix - FAIL - 0.87 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth
Bjorn Andersson April 11, 2022, 9:04 p.m. UTC | #2
On Tue 22 Mar 03:31 CDT 2022, Sai Teja Aluvala wrote:

> Add IO regulator handler in SC7280 CRD based platforms.
> As IO regulator varies in different SC7280 platforms
> updating this handler in individual platform bluetooth node.
> 

To me a significant part of this change is "bluetooth", yet it's not
mentioned until the very end of the commit message.

Please update your $subject to be more to the point and to include
"bluetooth", and please don't repeat $subject as the first line in your
commit message.

Thanks,
Bjorn

> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> ---
> v3: Updated commit text to reflect the change
> v2: updated reviewer comments.
> v1: intial patch
> ---
> ---
>  arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index cd2755c..53ea3b4 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -23,6 +23,10 @@
>  	};
>  };
>  
> +&bluetooth {
> +	vddio-supply = <&vreg_l18b_1p8>;
> +};
> +
>  ap_tp_i2c: &i2c0 {
>  	status = "okay";
>  	clock-frequency = <400000>;
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
index cd2755c..53ea3b4 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
@@ -23,6 +23,10 @@ 
 	};
 };
 
+&bluetooth {
+	vddio-supply = <&vreg_l18b_1p8>;
+};
+
 ap_tp_i2c: &i2c0 {
 	status = "okay";
 	clock-frequency = <400000>;