| Message ID | 20220409105958.37412-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Commit | 87950929e2ff2236207bdbe14bff8230558b541b |
| Headers | show |
| Series | [-next] pinctrl: mediatek: moore: Fix build error | expand |
On Sat, Apr 9, 2022 at 1:00 PM YueHaibing <yuehaibing@huawei.com> wrote: > If EINT_MTK is m and PINCTRL_MTK_V2 is y, build fails: > > drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_set_config': > pinctrl-moore.c:(.text+0xa6c): undefined reference to `mtk_eint_set_debounce' > drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_to_irq': > pinctrl-moore.c:(.text+0xacc): undefined reference to `mtk_eint_find_irq' > > Select EINT_MTK for PINCTRL_MTK_V2 to fix this. > > Fixes: 8174a8512e3e ("pinctrl: mediatek: make MediaTek pinctrl v2 driver ready for buidling loadable module") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Good catch! Patch applied for fixes. Yours, Linus Walleij
diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig index 8dca1ef04965..40accd110c3d 100644 --- a/drivers/pinctrl/mediatek/Kconfig +++ b/drivers/pinctrl/mediatek/Kconfig @@ -30,6 +30,7 @@ config PINCTRL_MTK_MOORE select GENERIC_PINMUX_FUNCTIONS select GPIOLIB select OF_GPIO + select EINT_MTK select PINCTRL_MTK_V2 config PINCTRL_MTK_PARIS
If EINT_MTK is m and PINCTRL_MTK_V2 is y, build fails: drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_set_config': pinctrl-moore.c:(.text+0xa6c): undefined reference to `mtk_eint_set_debounce' drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_to_irq': pinctrl-moore.c:(.text+0xacc): undefined reference to `mtk_eint_find_irq' Select EINT_MTK for PINCTRL_MTK_V2 to fix this. Fixes: 8174a8512e3e ("pinctrl: mediatek: make MediaTek pinctrl v2 driver ready for buidling loadable module") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/pinctrl/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+)