diff mbox series

[v3,2/3] tty: n_gsm: clean up dead code in gsm_queue()

Message ID 20220420101346.3315-2-daniel.starke@siemens.com
State New
Headers show
Series None | expand

Commit Message

D. Starke April 20, 2022, 10:13 a.m. UTC
From: Daniel Starke <daniel.starke@siemens.com>

Remove commented out code as it is never used and if anyone accidentally
turned it on, it would be broken.

Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
---
 drivers/tty/n_gsm.c | 4 ----
 1 file changed, 4 deletions(-)

The commit title and message was adjusted as recommended in the remarks for
the original patch. This is only a cleanup now and not a fix. The remark
for backporting was also removed. The code change remains as it was
originally.
This is version 3 of the patch because the second version was missing the
change remarks.

Link: https://lore.kernel.org/all/YlkRO6fAPCuWyT1Y@kroah.com/
diff mbox series

Patch

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 07d03447cdfd..1b4077006744 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1894,10 +1894,6 @@  static void gsm_queue(struct gsm_mux *gsm)
 	case UI|PF:
 	case UIH:
 	case UIH|PF:
-#if 0
-		if (cr)
-			goto invalid;
-#endif
 		if (dlci == NULL || dlci->state != DLCI_OPEN) {
 			gsm_command(gsm, address, DM|PF);
 			return;