diff mbox series

[2/2] mailbox: imx: fix duplicated initializer

Message ID 20220501103428.111286-2-krzysztof.kozlowski@linaro.org
State New
Headers show
Series None | expand

Commit Message

Krzysztof Kozlowski May 1, 2022, 10:34 a.m. UTC
rxdb field is being initialized twice:

  drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [-Werror=override-init]
    889 |         .rxdb   = imx_mu_generic_rxdb,

Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/mailbox/imx-mailbox.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Peng Fan May 7, 2022, 6:52 a.m. UTC | #1
> Subject: [PATCH 2/2] mailbox: imx: fix duplicated initializer
> 
> rxdb field is being initialized twice:
> 
>   drivers/mailbox/imx-mailbox.c:889:19: error: initialized field overwritten [-
> Werror=override-init]
>     889 |         .rxdb   = imx_mu_generic_rxdb,
> 
> Fixes: 315d2e562418 ("mailbox: imx: introduce rxdb callback")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
>  drivers/mailbox/imx-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index e88f544a1548..df8a785be324 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -886,7 +886,6 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp =
> {
>  	.rx	= imx_mu_generic_rx,
>  	.rxdb	= imx_mu_generic_rxdb,
>  	.init	= imx_mu_init_generic,
> -	.rxdb	= imx_mu_generic_rxdb,
>  	.type	= IMX_MU_V2,
>  	.xTR	= 0x200,
>  	.xRR	= 0x280,
> --
> 2.32.0
diff mbox series

Patch

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index e88f544a1548..df8a785be324 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -886,7 +886,6 @@  static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
 	.rx	= imx_mu_generic_rx,
 	.rxdb	= imx_mu_generic_rxdb,
 	.init	= imx_mu_init_generic,
-	.rxdb	= imx_mu_generic_rxdb,
 	.type	= IMX_MU_V2,
 	.xTR	= 0x200,
 	.xRR	= 0x280,