| Message ID | 20220511220613.1015472-6-marijn.suijten@somainline.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/7] arm64: dts: qcom: pm660: Use unique ADC5_VCOIN address in node name | expand |
On 12/05/2022 00:06, Marijn Suijten wrote: > This PMIC is commonly used on boards with an SM6125 SoC and looks very > similar in layout to the PM6150. > > Downstream declares more nodes to be available, but these have been > omitted from this patch: the pwm/lpg block is unused on my reference > device making it impossible to test/validate, and the spmi-clkdiv does > not have a single device-tree binding using this driver yet, hence > inclusion is better postponed until ie. audio which uses these clocks is > brought up. > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Two reviews on first patch... :) > + > + pmic@1 { > + compatible = "qcom,pm6125", "qcom,spmi-pmic"; > + reg = <0x1 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; No children, so this should not be needed, I think. > + }; > +}; Best regards, Krzysztof
On 2022-05-13 10:24:04, Krzysztof Kozlowski wrote: > On 12/05/2022 00:06, Marijn Suijten wrote: > > This PMIC is commonly used on boards with an SM6125 SoC and looks very > > similar in layout to the PM6150. > > > > Downstream declares more nodes to be available, but these have been > > omitted from this patch: the pwm/lpg block is unused on my reference > > device making it impossible to test/validate, and the spmi-clkdiv does > > not have a single device-tree binding using this driver yet, hence > > inclusion is better postponed until ie. audio which uses these clocks is > > brought up. > > > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > > Two reviews on first patch... :) Same story here, we review each-others patches in advance and it'd be annoying to have them re-send their approval through the mailing list; only for me/us to pick it up in a v2. > > + > > + pmic@1 { > > + compatible = "qcom,pm6125", "qcom,spmi-pmic"; > > + reg = <0x1 SPMI_USID>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > No children, so this should not be needed, I think. The size-cells or the entire node? There's a PWM/LPG block here according to downstream DT, but my device doesn't use it so I can't test that it is valid. I can add it anyway, presuming reviewers here have the ability to validate it for me with a reference manual. - Marijn
On 13/05/2022 11:25, Marijn Suijten wrote: >>> + #address-cells = <1>; >>> + #size-cells = <0>; >> >> No children, so this should not be needed, I think. > > The size-cells or the entire node? There's a PWM/LPG block here > according to downstream DT, but my device doesn't use it so I can't test > that it is valid. I can add it anyway, presuming reviewers here have > the ability to validate it for me with a reference manual. I mean only the address/size cells. They are needed for the children, unless some binding expects it? Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/pm6125.dtsi b/arch/arm64/boot/dts/qcom/pm6125.dtsi new file mode 100644 index 000000000000..5028001f8213 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/pm6125.dtsi @@ -0,0 +1,156 @@ +// SPDX-License-Identifier: BSD-3-Clause + +#include <dt-bindings/iio/qcom,spmi-vadc.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/input/linux-event-codes.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/spmi/spmi.h> + +/ { + thermal-zones { + pm6125-thermal { + polling-delay-passive = <100>; + polling-delay = <0>; + + thermal-sensors = <&pm6125_temp>; + + trips { + trip0 { + temperature = <95000>; + hysteresis = <0>; + type = "passive"; + }; + + trip1 { + temperature = <115000>; + hysteresis = <0>; + type = "hot"; + }; + + trip2 { + temperature = <145000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; +}; + +&spmi_bus { + pmic@0 { + compatible = "qcom,pm6125", "qcom,spmi-pmic"; + reg = <0x0 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + pm6125_pon: pon@800 { + compatible = "qcom,pm8998-pon"; + reg = <0x800>; + mode-bootloader = <0x2>; + mode-recovery = <0x1>; + + pon_pwrkey: pwrkey { + compatible = "qcom,pm8941-pwrkey"; + interrupts = <0x0 0x8 0x0 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + linux,code = <KEY_POWER>; + bias-pull-up; + status = "disabled"; + }; + + pon_resin: resin { + compatible = "qcom,pm8941-resin"; + interrupts = <0x0 0x8 0x1 IRQ_TYPE_EDGE_BOTH>; + debounce = <15625>; + bias-pull-up; + status = "disabled"; + }; + }; + + pm6125_temp: temp-alarm@2400 { + compatible = "qcom,spmi-temp-alarm"; + reg = <0x2400>; + interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>; + io-channels = <&pm6125_adc ADC5_DIE_TEMP>; + io-channel-names = "thermal"; + #thermal-sensor-cells = <0>; + }; + + pm6125_adc: adc@3100 { + compatible = "qcom,spmi-adc5"; + reg = <0x3100>; + #address-cells = <1>; + #size-cells = <0>; + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; + #io-channel-cells = <1>; + + ref-gnd@0 { + reg = <ADC5_REF_GND>; + qcom,pre-scaling = <1 1>; + }; + + vref-1p25@1 { + reg = <ADC5_1P25VREF>; + qcom,pre-scaling = <1 1>; + }; + + die-temp@6 { + reg = <ADC5_DIE_TEMP>; + qcom,pre-scaling = <1 1>; + }; + + vph-pwr@83 { + reg = <ADC5_VPH_PWR>; + qcom,pre-scaling = <1 3>; + }; + + vcoin@85 { + reg = <ADC5_VCOIN>; + qcom,pre-scaling = <1 3>; + }; + + xo-therm@4c { + reg = <ADC5_XO_THERM_100K_PU>; + qcom,pre-scaling = <1 1>; + qcom,hw-settle-time = <200>; + qcom,ratiometric; + }; + }; + + pm6125_adc_tm: adc-tm@3500 { + compatible = "qcom,spmi-adc-tm5"; + reg = <0x3500>; + interrupts = <0x0 0x35 0x0 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; + #thermal-sensor-cells = <1>; + status = "disabled"; + }; + + pm6125_rtc: rtc@6000 { + compatible = "qcom,pm8941-rtc"; + reg = <0x6000>, <0x6100>; + reg-names = "rtc", "alarm"; + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; + status = "disabled"; + }; + + pm6125_gpio: gpios@c000 { + compatible = "qcom,pm6125-gpio", "qcom,spmi-gpio"; + reg = <0xc000>; + gpio-controller; + gpio-ranges = <&pm6125_gpio 0 0 9>; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + }; + }; + + pmic@1 { + compatible = "qcom,pm6125", "qcom,spmi-pmic"; + reg = <0x1 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + }; +};