| Message ID | 20220606200203.22938-1-quic_amelende@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: power: reset: qcom-pon: update "reg" property details | expand |
Hi, On Mon, Jun 06, 2022 at 01:02:05PM -0700, Anjelique Melendez wrote: > From: David Collins <quic_collinsd@quicinc.com> > > Update the description of "reg" property to add the PON_PBS base > address along with PON_HLOS base address. Also add "reg-names" > property description. > > Signed-off-by: David Collins <quic_collinsd@quicinc.com> > Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> > --- > > New patch series to sperate this patch from applied patches. > Last comments from original patch series can be found > https://lore.kernel.org/linux-arm-msm/27515993-18f3-8891-4835-9b6a8d7f86b0@quicinc.com/ > > bindings/power/reset/qcom,pon.yaml | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/bindings/power/reset/qcom,pon.yaml b/bindings/power/reset/qcom,pon.yaml uhm... the path is missing Documentation/devicetree prefix, so this obviously would not apply. Then you missed adding Krzysztof to CC. I will not apply this without an explicit Ack from DT binding maintainers. Also I suppose GEN1/GEN2/GEN3 is something that can be inferred from the compatible string, so the binding can limit the allowed options based on that. -- Sebastian > index 353f155d..1d8cf900 100644 > --- a/bindings/power/reset/qcom,pon.yaml > +++ b/bindings/power/reset/qcom,pon.yaml > @@ -26,8 +26,26 @@ properties: > - qcom,pm8998-pon > > reg: > - maxItems: 1 > + description: | > + Specifies the SPMI base address for the PON (power-on) peripheral. For > + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS > + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS > + peripherals. In that case, the PON_PBS address needs to be specified to > + facilitate software debouncing on some PMICs. > + minItems: 1 > + maxItems: 2 > > + reg-names: > + description: | > + For PON GEN1 and GEN2, it should be "pon". For PON GEN3 it should include > + "pon_hlos" and optionally "pon_pbs". > + minItems: 1 > + maxItems: 2 > + items: > + anyOf: > + - const: pon_hlos > + - const: pon_pbs > + - const: pon > pwrkey: > type: object > $ref: "../../input/qcom,pm8941-pwrkey.yaml#" > -- > 2.35.1 >
diff --git a/bindings/power/reset/qcom,pon.yaml b/bindings/power/reset/qcom,pon.yaml index 353f155d..1d8cf900 100644 --- a/bindings/power/reset/qcom,pon.yaml +++ b/bindings/power/reset/qcom,pon.yaml @@ -26,8 +26,26 @@ properties: - qcom,pm8998-pon reg: - maxItems: 1 + description: | + Specifies the SPMI base address for the PON (power-on) peripheral. For + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS + peripherals. In that case, the PON_PBS address needs to be specified to + facilitate software debouncing on some PMICs. + minItems: 1 + maxItems: 2 + reg-names: + description: | + For PON GEN1 and GEN2, it should be "pon". For PON GEN3 it should include + "pon_hlos" and optionally "pon_pbs". + minItems: 1 + maxItems: 2 + items: + anyOf: + - const: pon_hlos + - const: pon_pbs + - const: pon pwrkey: type: object $ref: "../../input/qcom,pm8941-pwrkey.yaml#"