| Message ID | 20220610090005.1358402-1-javierm@redhat.com |
|---|---|
| State | Accepted |
| Commit | 34705a57e7df97d161324263c103c4d4d120dfe7 |
| Headers | show |
| Series | efi: sysfb_efi: remove unnecessary <asm/efi.h> include | expand |
On Fri, 10 Jun 2022 at 11:00, Javier Martinez Canillas <javierm@redhat.com> wrote: > > Nothing defined in the header is used by drivers/firmware/efi/sysfb_efi.c > but also, including it can lead to build errors when built on arches that > don't have an asm/efi.h header file. > > This can happen for example if a driver that is built when COMPILE_TEST is > enabled selects the SYSFB symbol, e.g. on powerpc with allyesconfig: > > drivers/firmware/efi/sysfb_efi.c:29:10: fatal error: asm/efi.h: No such file or directory > 29 | #include <asm/efi.h> > | ^~~~~~~~~~~ > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Queued up in efi/urgent, thanks > --- > > drivers/firmware/efi/sysfb_efi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c > index 4c7c9dd7733f..7882d4b3f2be 100644 > --- a/drivers/firmware/efi/sysfb_efi.c > +++ b/drivers/firmware/efi/sysfb_efi.c > @@ -26,8 +26,6 @@ > #include <linux/sysfb.h> > #include <video/vga.h> > > -#include <asm/efi.h> > - > enum { > OVERRIDE_NONE = 0x0, > OVERRIDE_BASE = 0x1, > -- > 2.36.1 >
diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c index 4c7c9dd7733f..7882d4b3f2be 100644 --- a/drivers/firmware/efi/sysfb_efi.c +++ b/drivers/firmware/efi/sysfb_efi.c @@ -26,8 +26,6 @@ #include <linux/sysfb.h> #include <video/vga.h> -#include <asm/efi.h> - enum { OVERRIDE_NONE = 0x0, OVERRIDE_BASE = 0x1,
Nothing defined in the header is used by drivers/firmware/efi/sysfb_efi.c but also, including it can lead to build errors when built on arches that don't have an asm/efi.h header file. This can happen for example if a driver that is built when COMPILE_TEST is enabled selects the SYSFB symbol, e.g. on powerpc with allyesconfig: drivers/firmware/efi/sysfb_efi.c:29:10: fatal error: asm/efi.h: No such file or directory 29 | #include <asm/efi.h> | ^~~~~~~~~~~ Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- drivers/firmware/efi/sysfb_efi.c | 2 -- 1 file changed, 2 deletions(-)