diff mbox series

gpio: xgs-iproc: Drop if with an always false condition

Message ID 20220615124718.304719-1-u.kleine-koenig@pengutronix.de
State Accepted
Commit 3d57fa2a228c973032e94aceeef92a3e9704b9ea
Headers show
Series gpio: xgs-iproc: Drop if with an always false condition | expand

Commit Message

Uwe Kleine-König June 15, 2022, 12:47 p.m. UTC 
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so chip is never NULL.

Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm
callbacks are called.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/gpio/gpio-xgs-iproc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)


base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
index 43ca52fa6f9a..fd88500399c6 100644
--- a/drivers/gpio/gpio-xgs-iproc.c
+++ b/drivers/gpio/gpio-xgs-iproc.c
@@ -281,11 +281,7 @@  static int iproc_gpio_probe(struct platform_device *pdev)
 
 static int iproc_gpio_remove(struct platform_device *pdev)
 {
-	struct iproc_gpio_chip *chip;
-
-	chip = platform_get_drvdata(pdev);
-	if (!chip)
-		return -ENODEV;
+	struct iproc_gpio_chip *chip = platform_get_drvdata(pdev);
 
 	if (chip->intr) {
 		u32 val;