diff mbox series

Bluetooth: hci_sync: cancel cmd_timer if hci_open failed

Message ID 20221005150934.1.Ife932473db2eec6f0bc54226c3328e5fa8c5f97b@changeid
State New
Headers show
Series Bluetooth: hci_sync: cancel cmd_timer if hci_open failed | expand

Commit Message

Archie Pusaka Oct. 5, 2022, 7:09 a.m. UTC 
From: Archie Pusaka <apusaka@chromium.org>

If a command is already sent, we take care of freeing it, but we
also need to cancel the timeout as well.

Signed-off-by: Archie Pusaka <apusaka@chromium.org>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>

---

 net/bluetooth/hci_sync.c | 1 +
 1 file changed, 1 insertion(+)

Comments

bluez.test.bot@gmail.com Oct. 5, 2022, 7:35 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=683158

---Test result---

Test Summary:
CheckPatch                    PASS      2.38 seconds
GitLint                       PASS      0.79 seconds
SubjectPrefix                 PASS      0.69 seconds
BuildKernel                   PASS      49.88 seconds
BuildKernel32                 PASS      41.45 seconds
Incremental Build with patchesPASS      54.45 seconds
TestRunner: Setup             PASS      731.82 seconds
TestRunner: l2cap-tester      PASS      17.16 seconds
TestRunner: iso-tester        PASS      16.55 seconds
TestRunner: bnep-tester       PASS      6.21 seconds
TestRunner: mgmt-tester       PASS      106.64 seconds
TestRunner: rfcomm-tester     PASS      10.10 seconds
TestRunner: sco-tester        PASS      9.29 seconds
TestRunner: ioctl-tester      PASS      10.61 seconds
TestRunner: smp-tester        PASS      9.48 seconds
TestRunner: userchan-tester   PASS      6.49 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Oct. 11, 2022, 7:40 p.m. UTC | #2 
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed,  5 Oct 2022 15:09:47 +0800 you wrote:
> From: Archie Pusaka <apusaka@chromium.org>
> 
> If a command is already sent, we take care of freeing it, but we
> also need to cancel the timeout as well.
> 
> Signed-off-by: Archie Pusaka <apusaka@chromium.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>
> 
> [...]

Here is the summary with links:
  - Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
    https://git.kernel.org/bluetooth/bluetooth-next/c/64b5c4c8e79c

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 76c3107c9f91..a011065220e4 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4696,6 +4696,7 @@  int hci_dev_open_sync(struct hci_dev *hdev)
 			hdev->flush(hdev);
 
 		if (hdev->sent_cmd) {
+			cancel_delayed_work_sync(&hdev->cmd_timer);
 			kfree_skb(hdev->sent_cmd);
 			hdev->sent_cmd = NULL;
 		}