| Message ID | 20221021190908.1502026-2-nfraprado@collabora.com |
|---|---|
| State | Accepted |
| Commit | 1c44873993d97f1da264ae9a7adb336d6af8ff9b |
| Headers | show |
| Series | Add missing dt-binding properties to rt5682(s) | expand |
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com> On 21/10/2022 21:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can be pointed to through a sound-dai property to be > used as part of a machine sound driver. dtc expects #sound-dai-cells to > be defined in the codec's node in those cases, so add it in the > dt-binding and set it to 0. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > index ca5b8987b749..ea53a55015c4 100644 > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml > @@ -87,6 +87,9 @@ properties: > maxItems: 2 > description: Name given for DAI word clock and bit clock outputs. > > + "#sound-dai-cells": > + const: 0 > + > additionalProperties: false > > required:
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > The rt5682s codec can be pointed to through a sound-dai property to be > used as part of a machine sound driver. dtc expects #sound-dai-cells to > be defined in the codec's node in those cases, so add it in the > dt-binding and set it to 0. Drop the entire last sentence, it's not really relevant to the problem. What if we name compiler not dtc, but ctd? It's redundant and actually forces reader to read unrelated stuff, instead of focusing on the root problem - this is a DAI provider. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index ca5b8987b749..ea53a55015c4 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -87,6 +87,9 @@ properties: maxItems: 2 description: Name given for DAI word clock and bit clock outputs. + "#sound-dai-cells": + const: 0 + additionalProperties: false required:
The rt5682s codec can be pointed to through a sound-dai property to be used as part of a machine sound driver. dtc expects #sound-dai-cells to be defined in the codec's node in those cases, so add it in the dt-binding and set it to 0. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 3 +++ 1 file changed, 3 insertions(+)