diff mbox

drivers/net/usb/smsc95xx.c: change msleep() to usleep_range()

Message ID 4F104A93.4060606@linaro.org
State New
Headers show

Commit Message

Dmitry Antipov Jan. 13, 2012, 3:15 p.m. UTC 
Due to git-send-email misconfiguration, this wasn't CC:ed to patches@linaro.org :-(.

-------- Original Message --------
Subject: [PATCH] drivers/net/usb/smsc95xx.c: change msleep() to usleep_range()
Date: Fri, 13 Jan 2012 15:57:04 +0400
From: Dmitry Antipov <dmitry.antipov@linaro.org>
To: Steve Glendinning <steve.glendinning@smsc.com>
CC: Greg Kroah-Hartman <gregkh@suse.de>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Antipov <dmitry.antipov@linaro.org>

The resolution of msleep is related to HZ, so 10ms msleep() causes
~23ms sleep with OMAP's default CONFIG_HZ=128 timer configuration.
This looks too much, and usleep_range() with some slack gives more
control of what is happening here.

Signed-off-by: Dmitry Antipov <dmitry.antipov@linaro.org>
---
  drivers/net/usb/smsc95xx.c |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index d45520e..5d406d4 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -688,7 +688,7 @@  static int smsc95xx_phy_initialize(struct usbnet *dev)
  	smsc95xx_mdio_write(dev->net, dev->mii.phy_id, MII_BMCR, BMCR_RESET);

  	do {
-		msleep(10);
+		usleep_range(10000, 15000);
  		bmcr = smsc95xx_mdio_read(dev->net, dev->mii.phy_id, MII_BMCR);
  		timeout++;
  	} while ((bmcr & BMCR_RESET) && (timeout < 100));
@@ -736,7 +736,7 @@  static int smsc95xx_reset(struct usbnet *dev)
  			netdev_warn(dev->net, "Failed to read HW_CFG: %d\n", ret);
  			return ret;
  		}
-		msleep(10);
+		usleep_range(10000, 15000);
  		timeout++;
  	} while ((read_buf & HW_CFG_LRST_) && (timeout < 100));

@@ -759,7 +759,7 @@  static int smsc95xx_reset(struct usbnet *dev)
  			netdev_warn(dev->net, "Failed to read PM_CTRL: %d\n", ret);
  			return ret;
  		}
-		msleep(10);
+		usleep_range(10000, 15000);
  		timeout++;
  	} while ((read_buf & PM_CTL_PHY_RST_) && (timeout < 100));