| Message ID | db30127ab4741d4e71b768881197f4791174f545.1666786471.git.matthias.schiffer@ew.tq-group.com |
|---|---|
| State | New |
| Headers | show |
| Series | "notify-device" for cross-driver readiness notification | expand |
This is an automated email and please do not reply to this email. Dear Submitter, Thank you for submitting the patches to the linux bluetooth mailing list. While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository. ----- Output ----- error: patch failed: drivers/misc/Makefile:62 error: drivers/misc/Makefile: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch Please resolve the issue and submit the patches again. --- Regards, Linux Bluetooth
On Wed, Oct 26, 2022 at 03:15:30PM +0200, Matthias Schiffer wrote: > A notify-device is a synchronization facility that allows to query > "readiness" across drivers, without creating a direct dependency between > the driver modules. The notify-device can also be used to trigger deferred > probes. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > --- > drivers/misc/Kconfig | 4 ++ > drivers/misc/Makefile | 1 + > drivers/misc/notify-device.c | 109 ++++++++++++++++++++++++++++++++++ > include/linux/notify-device.h | 33 ++++++++++ > 4 files changed, 147 insertions(+) > create mode 100644 drivers/misc/notify-device.c > create mode 100644 include/linux/notify-device.h > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 358ad56f6524..63559e9f854c 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -496,6 +496,10 @@ config VCPU_STALL_DETECTOR > > If you do not intend to run this kernel as a guest, say N. > > +config NOTIFY_DEVICE > + tristate "Notify device" > + depends on OF > + > source "drivers/misc/c2port/Kconfig" > source "drivers/misc/eeprom/Kconfig" > source "drivers/misc/cb710/Kconfig" > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index ac9b3e757ba1..1e8012112b43 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -62,3 +62,4 @@ obj-$(CONFIG_HI6421V600_IRQ) += hi6421v600-irq.o > obj-$(CONFIG_OPEN_DICE) += open-dice.o > obj-$(CONFIG_GP_PCI1XXXX) += mchp_pci1xxxx/ > obj-$(CONFIG_VCPU_STALL_DETECTOR) += vcpu_stall_detector.o > +obj-$(CONFIG_NOTIFY_DEVICE) += notify-device.o > diff --git a/drivers/misc/notify-device.c b/drivers/misc/notify-device.c > new file mode 100644 > index 000000000000..42e0980394ea > --- /dev/null > +++ b/drivers/misc/notify-device.c > @@ -0,0 +1,109 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > + > +#include <linux/device/class.h> > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/notify-device.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > + > +static void notify_device_release(struct device *dev) > +{ > + of_node_put(dev->of_node); > + kfree(dev); > +} > + > +static struct class notify_device_class = { > + .name = "notify-device", > + .owner = THIS_MODULE, > + .dev_release = notify_device_release, > +}; > + > +static struct platform_driver notify_device_driver = { Ick, wait, this is NOT a platform device, nor driver, so it shouldn't be either here. Worst case, it's a virtual device on the virtual bus. But why is this a class at all? Classes are a representation of a type of device that userspace can see, how is this anything that userspace cares about? Doesn't the device link stuff handle all of this type of "when this device is done being probed, now I can" problems? Why is a whole new thing needed? thanks, greg k-h
On Wed, 2022-10-26 at 16:37 +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 26, 2022 at 03:15:30PM +0200, Matthias Schiffer wrote: > > A notify-device is a synchronization facility that allows to query > > "readiness" across drivers, without creating a direct dependency between > > the driver modules. The notify-device can also be used to trigger deferred > > probes. > > > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > > --- > > drivers/misc/Kconfig | 4 ++ > > drivers/misc/Makefile | 1 + > > drivers/misc/notify-device.c | 109 ++++++++++++++++++++++++++++++++++ > > include/linux/notify-device.h | 33 ++++++++++ > > 4 files changed, 147 insertions(+) > > create mode 100644 drivers/misc/notify-device.c > > create mode 100644 include/linux/notify-device.h > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > index 358ad56f6524..63559e9f854c 100644 > > --- a/drivers/misc/Kconfig > > +++ b/drivers/misc/Kconfig > > @@ -496,6 +496,10 @@ config VCPU_STALL_DETECTOR > > > > If you do not intend to run this kernel as a guest, say N. > > > > +config NOTIFY_DEVICE > > + tristate "Notify device" > > + depends on OF > > + > > source "drivers/misc/c2port/Kconfig" > > source "drivers/misc/eeprom/Kconfig" > > source "drivers/misc/cb710/Kconfig" > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > index ac9b3e757ba1..1e8012112b43 100644 > > --- a/drivers/misc/Makefile > > +++ b/drivers/misc/Makefile > > @@ -62,3 +62,4 @@ obj-$(CONFIG_HI6421V600_IRQ) += hi6421v600-irq.o > > obj-$(CONFIG_OPEN_DICE) += open-dice.o > > obj-$(CONFIG_GP_PCI1XXXX) += mchp_pci1xxxx/ > > obj-$(CONFIG_VCPU_STALL_DETECTOR) += vcpu_stall_detector.o > > +obj-$(CONFIG_NOTIFY_DEVICE) += notify-device.o > > diff --git a/drivers/misc/notify-device.c b/drivers/misc/notify-device.c > > new file mode 100644 > > index 000000000000..42e0980394ea > > --- /dev/null > > +++ b/drivers/misc/notify-device.c > > @@ -0,0 +1,109 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > + > > +#include <linux/device/class.h> > > +#include <linux/kernel.h> > > +#include <linux/module.h> > > +#include <linux/notify-device.h> > > +#include <linux/platform_device.h> > > +#include <linux/slab.h> > > + > > +static void notify_device_release(struct device *dev) > > +{ > > + of_node_put(dev->of_node); > > + kfree(dev); > > +} > > + > > +static struct class notify_device_class = { > > + .name = "notify-device", > > + .owner = THIS_MODULE, > > + .dev_release = notify_device_release, > > +}; > > + > > +static struct platform_driver notify_device_driver = { [Pruning the CC list a bit, to avoid clogging people's inboxes] > > Ick, wait, this is NOT a platform device, nor driver, so it shouldn't be > either here. Worst case, it's a virtual device on the virtual bus. This part of the code is inspired by mac80211_hwsim, which uses a platform driver in a similar way, for a plain struct device. Should this rather use a plain struct device_driver? Also, what's the virtual bus? Grepping the Linux code and documentation didn't turn up anything. > > But why is this a class at all? Classes are a representation of a type > of device that userspace can see, how is this anything that userspace > cares about? Makes sense, I will remove the class. > > Doesn't the device link stuff handle all of this type of "when this > device is done being probed, now I can" problems? Why is a whole new > thing needed? The issue here is that (as I understand it) the device link and deferred probing infrastructore only cares about whether the supplier device has been probed successfully. This is insuffient in the case of the dependency between mwifiex and hci_uart/hci_mrvl that I want to express: mwifiex loads its firmware asynchronously, so finishing the mwifiex probe is too early to retry probing the Bluetooth driver. While mwifiex does create a few devices (ieee80211, netdevice) when the firmware has loaded, none of these bind to a driver, so they don't trigger the deferred probes. Using their existence as a condition for allowing the Bluetooth driver to probe also seems ugly too me (ieee80211 currently can't be looked up by OF node, and netdevices can be created and deleted dynamically). Because of this, I came to the conclusion that creating and binding a device specifically for this purpose is a good solution, as it solves two problems at once: - The driver bind triggers deferred probes - The driver allows to look up the device by OF node Integrating this with device links might make sense as well, but I haven't looked much into that yet. Thanks, Matthias > > thanks, > > greg k-h
On Thu, Oct 27, 2022 at 06:33:33PM +0200, Matthias Schiffer wrote: > On Wed, 2022-10-26 at 16:37 +0200, Greg Kroah-Hartman wrote: > > On Wed, Oct 26, 2022 at 03:15:30PM +0200, Matthias Schiffer wrote: > > > A notify-device is a synchronization facility that allows to query > > > "readiness" across drivers, without creating a direct dependency between > > > the driver modules. The notify-device can also be used to trigger deferred > > > probes. > > > > > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > > > --- > > > drivers/misc/Kconfig | 4 ++ > > > drivers/misc/Makefile | 1 + > > > drivers/misc/notify-device.c | 109 ++++++++++++++++++++++++++++++++++ > > > include/linux/notify-device.h | 33 ++++++++++ > > > 4 files changed, 147 insertions(+) > > > create mode 100644 drivers/misc/notify-device.c > > > create mode 100644 include/linux/notify-device.h > > > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > > index 358ad56f6524..63559e9f854c 100644 > > > --- a/drivers/misc/Kconfig > > > +++ b/drivers/misc/Kconfig > > > @@ -496,6 +496,10 @@ config VCPU_STALL_DETECTOR > > > > > > If you do not intend to run this kernel as a guest, say N. > > > > > > +config NOTIFY_DEVICE > > > + tristate "Notify device" > > > + depends on OF > > > + > > > source "drivers/misc/c2port/Kconfig" > > > source "drivers/misc/eeprom/Kconfig" > > > source "drivers/misc/cb710/Kconfig" > > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > > index ac9b3e757ba1..1e8012112b43 100644 > > > --- a/drivers/misc/Makefile > > > +++ b/drivers/misc/Makefile > > > @@ -62,3 +62,4 @@ obj-$(CONFIG_HI6421V600_IRQ) += hi6421v600-irq.o > > > obj-$(CONFIG_OPEN_DICE) += open-dice.o > > > obj-$(CONFIG_GP_PCI1XXXX) += mchp_pci1xxxx/ > > > obj-$(CONFIG_VCPU_STALL_DETECTOR) += vcpu_stall_detector.o > > > +obj-$(CONFIG_NOTIFY_DEVICE) += notify-device.o > > > diff --git a/drivers/misc/notify-device.c b/drivers/misc/notify-device.c > > > new file mode 100644 > > > index 000000000000..42e0980394ea > > > --- /dev/null > > > +++ b/drivers/misc/notify-device.c > > > @@ -0,0 +1,109 @@ > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > + > > > +#include <linux/device/class.h> > > > +#include <linux/kernel.h> > > > +#include <linux/module.h> > > > +#include <linux/notify-device.h> > > > +#include <linux/platform_device.h> > > > +#include <linux/slab.h> > > > + > > > +static void notify_device_release(struct device *dev) > > > +{ > > > + of_node_put(dev->of_node); > > > + kfree(dev); > > > +} > > > + > > > +static struct class notify_device_class = { > > > + .name = "notify-device", > > > + .owner = THIS_MODULE, > > > + .dev_release = notify_device_release, > > > +}; > > > + > > > +static struct platform_driver notify_device_driver = { > > [Pruning the CC list a bit, to avoid clogging people's inboxes] > > > > > Ick, wait, this is NOT a platform device, nor driver, so it shouldn't be > > either here. Worst case, it's a virtual device on the virtual bus. > > This part of the code is inspired by mac80211_hwsim, which uses a > platform driver in a similar way, for a plain struct device. Should > this rather use a plain struct device_driver? It should NOT be using a platform device. Again, a platform device should NEVER be used as a child of a device in the tree that is on a discoverable bus. Use the aux bus code if you don't want to create virtual devices with no real bus, that is what it is there for. > Also, what's the virtual bus? Grepping the Linux code and documentation > didn't turn up anything. Look at the stuff that ends up in /sys/devices/virtual/ Lots of users there. > > But why is this a class at all? Classes are a representation of a type > > of device that userspace can see, how is this anything that userspace > > cares about? > > Makes sense, I will remove the class. > > > > > Doesn't the device link stuff handle all of this type of "when this > > device is done being probed, now I can" problems? Why is a whole new > > thing needed? > > The issue here is that (as I understand it) the device link and > deferred probing infrastructore only cares about whether the supplier > device has been probed successfully. > > This is insuffient in the case of the dependency between mwifiex and > hci_uart/hci_mrvl that I want to express: mwifiex loads its firmware > asynchronously, so finishing the mwifiex probe is too early to retry > probing the Bluetooth driver. Welcome to deferred probing hell :) > While mwifiex does create a few devices (ieee80211, netdevice) when the > firmware has loaded, none of these bind to a driver, so they don't > trigger the deferred probes. Using their existence as a condition for > allowing the Bluetooth driver to probe also seems ugly too me > (ieee80211 currently can't be looked up by OF node, and netdevices can > be created and deleted dynamically). > > Because of this, I came to the conclusion that creating and binding a > device specifically for this purpose is a good solution, as it solves > two problems at once: > - The driver bind triggers deferred probes > - The driver allows to look up the device by OF node > > Integrating this with device links might make sense as well, but I > haven't looked much into that yet. Try looking at device links, I think this fits exactly what that solves. If not, please figure out why. thanks, greg k-h
On Thu, 2022-10-27 at 18:48 +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 27, 2022 at 06:33:33PM +0200, Matthias Schiffer wrote: > > On Wed, 2022-10-26 at 16:37 +0200, Greg Kroah-Hartman wrote: > > > On Wed, Oct 26, 2022 at 03:15:30PM +0200, Matthias Schiffer wrote: > > > > A notify-device is a synchronization facility that allows to query > > > > "readiness" across drivers, without creating a direct dependency between > > > > the driver modules. The notify-device can also be used to trigger deferred > > > > probes. > > > > > > > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > > > > --- > > > > drivers/misc/Kconfig | 4 ++ > > > > drivers/misc/Makefile | 1 + > > > > drivers/misc/notify-device.c | 109 ++++++++++++++++++++++++++++++++++ > > > > include/linux/notify-device.h | 33 ++++++++++ > > > > 4 files changed, 147 insertions(+) > > > > create mode 100644 drivers/misc/notify-device.c > > > > create mode 100644 include/linux/notify-device.h > > > > > > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > > > > index 358ad56f6524..63559e9f854c 100644 > > > > --- a/drivers/misc/Kconfig > > > > +++ b/drivers/misc/Kconfig > > > > @@ -496,6 +496,10 @@ config VCPU_STALL_DETECTOR > > > > > > > > If you do not intend to run this kernel as a guest, say N. > > > > > > > > +config NOTIFY_DEVICE > > > > + tristate "Notify device" > > > > + depends on OF > > > > + > > > > source "drivers/misc/c2port/Kconfig" > > > > source "drivers/misc/eeprom/Kconfig" > > > > source "drivers/misc/cb710/Kconfig" > > > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > > > index ac9b3e757ba1..1e8012112b43 100644 > > > > --- a/drivers/misc/Makefile > > > > +++ b/drivers/misc/Makefile > > > > @@ -62,3 +62,4 @@ obj-$(CONFIG_HI6421V600_IRQ) += hi6421v600-irq.o > > > > obj-$(CONFIG_OPEN_DICE) += open-dice.o > > > > obj-$(CONFIG_GP_PCI1XXXX) += mchp_pci1xxxx/ > > > > obj-$(CONFIG_VCPU_STALL_DETECTOR) += vcpu_stall_detector.o > > > > +obj-$(CONFIG_NOTIFY_DEVICE) += notify-device.o > > > > diff --git a/drivers/misc/notify-device.c b/drivers/misc/notify-device.c > > > > new file mode 100644 > > > > index 000000000000..42e0980394ea > > > > --- /dev/null > > > > +++ b/drivers/misc/notify-device.c > > > > @@ -0,0 +1,109 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > + > > > > +#include <linux/device/class.h> > > > > +#include <linux/kernel.h> > > > > +#include <linux/module.h> > > > > +#include <linux/notify-device.h> > > > > +#include <linux/platform_device.h> > > > > +#include <linux/slab.h> > > > > + > > > > +static void notify_device_release(struct device *dev) > > > > +{ > > > > + of_node_put(dev->of_node); > > > > + kfree(dev); > > > > +} > > > > + > > > > +static struct class notify_device_class = { > > > > + .name = "notify-device", > > > > + .owner = THIS_MODULE, > > > > + .dev_release = notify_device_release, > > > > +}; > > > > + > +static struct platform_driver notify_device_driver = { > > > > [Pruning the CC list a bit, to avoid clogging people's inboxes] > > > > > Ick, wait, this is NOT a platform device, nor driver, so it shouldn't be > > > either here. Worst case, it's a virtual device on the virtual bus. > > > > This part of the code is inspired by mac80211_hwsim, which uses a > > platform driver in a similar way, for a plain struct device. Should > > this rather use a plain struct device_driver? > > It should NOT be using a platform device. > > Again, a platform device should NEVER be used as a child of a device in > the tree that is on a discoverable bus. > > Use the aux bus code if you don't want to create virtual devices with no > real bus, that is what it is there for. Thanks, the auxiliary bus seems to be what I'm looking for. > > > Also, what's the virtual bus? Grepping the Linux code and documentation > > didn't turn up anything. > > Look at the stuff that ends up in /sys/devices/virtual/ Lots of users > there. > > > > But why is this a class at all? Classes are a representation of a type > > > of device that userspace can see, how is this anything that userspace > > > cares about? > > > > Makes sense, I will remove the class. > > > > > Doesn't the device link stuff handle all of this type of "when this > > > device is done being probed, now I can" problems? Why is a whole new > > > thing needed? > > > > The issue here is that (as I understand it) the device link and > > deferred probing infrastructore only cares about whether the supplier > > device has been probed successfully. > > > > This is insuffient in the case of the dependency between mwifiex and > > hci_uart/hci_mrvl that I want to express: mwifiex loads its firmware > > asynchronously, so finishing the mwifiex probe is too early to retry > > probing the Bluetooth driver. > > Welcome to deferred probing hell :) > > > While mwifiex does create a few devices (ieee80211, netdevice) when the > > firmware has loaded, none of these bind to a driver, so they don't > > trigger the deferred probes. Using their existence as a condition for > > allowing the Bluetooth driver to probe also seems ugly too me > > (ieee80211 currently can't be looked up by OF node, and netdevices can > > be created and deleted dynamically). > > > > Because of this, I came to the conclusion that creating and binding a > > device specifically for this purpose is a good solution, as it solves > > two problems at once: > > - The driver bind triggers deferred probes > > - The driver allows to look up the device by OF node > > > > Integrating this with device links might make sense as well, but I > > haven't looked much into that yet. > > Try looking at device links, I think this fits exactly what that solves. > If not, please figure out why. According to [1], what triggers device link state changes is the binding of drivers. As mentioned, this doesn't help in the mwifiex case: The mwifiex probe does not wait for the firmware to load, as the probe would otherwise take too long (see [2]). So unless we want to extend the device link facility with a manual mode where the supplier explicitly sets the link to a "ready" state, we still need to extend mwifiex with a child device to attach the link to, triggering the state change by binding it to a driver at the right moment. Which is what this patch implements in a generic way (just without device links so far). Thanks, Matthias [1] https://www.kernel.org/doc/html/latest/driver-api/device_link.html#state-machine [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=59a4cc2539076f868f2a3fcd7a3385a26928a27a
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 358ad56f6524..63559e9f854c 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -496,6 +496,10 @@ config VCPU_STALL_DETECTOR If you do not intend to run this kernel as a guest, say N. +config NOTIFY_DEVICE + tristate "Notify device" + depends on OF + source "drivers/misc/c2port/Kconfig" source "drivers/misc/eeprom/Kconfig" source "drivers/misc/cb710/Kconfig" diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index ac9b3e757ba1..1e8012112b43 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -62,3 +62,4 @@ obj-$(CONFIG_HI6421V600_IRQ) += hi6421v600-irq.o obj-$(CONFIG_OPEN_DICE) += open-dice.o obj-$(CONFIG_GP_PCI1XXXX) += mchp_pci1xxxx/ obj-$(CONFIG_VCPU_STALL_DETECTOR) += vcpu_stall_detector.o +obj-$(CONFIG_NOTIFY_DEVICE) += notify-device.o diff --git a/drivers/misc/notify-device.c b/drivers/misc/notify-device.c new file mode 100644 index 000000000000..42e0980394ea --- /dev/null +++ b/drivers/misc/notify-device.c @@ -0,0 +1,109 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include <linux/device/class.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/notify-device.h> +#include <linux/platform_device.h> +#include <linux/slab.h> + +static void notify_device_release(struct device *dev) +{ + of_node_put(dev->of_node); + kfree(dev); +} + +static struct class notify_device_class = { + .name = "notify-device", + .owner = THIS_MODULE, + .dev_release = notify_device_release, +}; + +static struct platform_driver notify_device_driver = { + .driver = { + .name = "notify-device", + }, +}; + +struct device *notify_device_create(struct device *parent, const char *child) +{ + struct device_node *node; + struct device *dev; + int err; + + if (!parent->of_node) + return ERR_PTR(-EINVAL); + + node = of_get_child_by_name(parent->of_node, child); + if (!node) + return NULL; + + dev = kzalloc(sizeof(*dev), GFP_KERNEL); + if (!dev) { + of_node_put(node); + return ERR_PTR(-ENOMEM); + } + + dev_set_name(dev, "%s:%s", dev_name(parent), child); + dev->class = ¬ify_device_class; + dev->parent = parent; + dev->of_node = node; + err = device_register(dev); + if (err) { + put_device(dev); + return ERR_PTR(err); + } + + dev->driver = ¬ify_device_driver.driver; + err = device_bind_driver(dev); + if (err) { + device_unregister(dev); + return ERR_PTR(err); + } + + return dev; +} +EXPORT_SYMBOL_GPL(notify_device_create); + +void notify_device_destroy(struct device *dev) +{ + if (!dev) + return; + + device_release_driver(dev); + device_unregister(dev); +} +EXPORT_SYMBOL_GPL(notify_device_destroy); + +struct device *notify_device_find_by_of_node(struct device_node *node) +{ + return class_find_device_by_of_node(¬ify_device_class, node); +} +EXPORT_SYMBOL_GPL(notify_device_find_by_of_node); + +static int __init notify_device_init(void) +{ + int err; + + err = class_register(¬ify_device_class); + if (err) + return err; + + err = platform_driver_register(¬ify_device_driver); + if (err) { + class_unregister(¬ify_device_class); + return err; + } + + return 0; +} + +static void __exit notify_device_exit(void) +{ + platform_driver_unregister(¬ify_device_driver); + class_unregister(¬ify_device_class); +} + +module_init(notify_device_init); +module_exit(notify_device_exit); +MODULE_LICENSE("GPL"); diff --git a/include/linux/notify-device.h b/include/linux/notify-device.h new file mode 100644 index 000000000000..f8c3e15d3b8f --- /dev/null +++ b/include/linux/notify-device.h @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _LINUX_NOTIFY_DEVICE_H +#define _LINUX_NOTIFY_DEVICE_H +#include <linux/device.h> +#include <linux/of.h> + +#ifdef CONFIG_NOTIFY_DEVICE + +struct device *notify_device_create(struct device *parent, const char *child); +void notify_device_destroy(struct device *dev); +struct device *notify_device_find_by_of_node(struct device_node *node); + +#else + +static inline struct device *notify_device_create(struct device *parent, + const char *child) +{ + return NULL; +} + +static inline void notify_device_destroy(struct device *dev) +{ +} + +static inline struct device *notify_device_find_by_of_node(struct device_node *node) +{ + return NULL; +} + +#endif + +#endif /* _LINUX_NOTIFY_DEVICE_H */
A notify-device is a synchronization facility that allows to query "readiness" across drivers, without creating a direct dependency between the driver modules. The notify-device can also be used to trigger deferred probes. Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> --- drivers/misc/Kconfig | 4 ++ drivers/misc/Makefile | 1 + drivers/misc/notify-device.c | 109 ++++++++++++++++++++++++++++++++++ include/linux/notify-device.h | 33 ++++++++++ 4 files changed, 147 insertions(+) create mode 100644 drivers/misc/notify-device.c create mode 100644 include/linux/notify-device.h