diff mbox series

[v2,4/5] dt-bindings: net: ipq4019-mdio: document required clock-names

Message ID 20221114194734.3287854-4-robimarko@gmail.com
State Accepted
Commit 4a8c14384fa96c0bd6c1a534667f2a72165faacf
Headers show
Series [v2,1/5] dt-bindings: net: ipq4019-mdio: document IPQ6018 compatible | expand

Commit Message

Robert Marko Nov. 14, 2022, 7:47 p.m. UTC
IPQ5018, IPQ6018 and IPQ8074 require clock-names to be set as driver is
requesting the clock based on it and not index, so document that and make
it required for the listed SoC-s.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
Changes in v2:
* Define clock-names under properties and disallow it per compatible
like clocks
---
 .../devicetree/bindings/net/qcom,ipq4019-mdio.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski Nov. 15, 2022, 8:15 a.m. UTC | #1
On 14/11/2022 20:47, Robert Marko wrote:
> IPQ5018, IPQ6018 and IPQ8074 require clock-names to be set as driver is
> requesting the clock based on it and not index, so document that and make
> it required for the listed SoC-s.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> Changes in v2:
> * Define clock-names under properties and disallow it per compatible
> like clocks
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
index 72561e3aeee3..7631ecc8fd01 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
@@ -40,6 +40,10 @@  properties:
     items:
       - description: MDIO clock source frequency fixed to 100MHZ
 
+  clock-names:
+    items:
+      - const: gcc_mdio_ahb_clk
+
 required:
   - compatible
   - reg
@@ -60,9 +64,11 @@  allOf:
     then:
       required:
         - clocks
+        - clock-names
     else:
       properties:
         clocks: false
+        clock-names: false
 
 unevaluatedProperties: false