diff mbox

[edk2] ArmPlatformPkg/IntelBds: call BdsLibConnectAll()

Message ID 1456309892-10895-1-git-send-email-leif.lindholm@linaro.org
State Accepted
Commit 50e8d3936c485af18fe1e946b814d4466517d34a
Headers show

Commit Message

Leif Lindholm Feb. 24, 2016, 10:31 a.m. UTC
Currently, we don't pick up removable media (USB drives) or storage
devices connected via plug-in cards. Take the sledge hammer approach
for now.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.1.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ryan Harkin Feb. 24, 2016, 10:34 a.m. UTC | #1
On 24 February 2016 at 10:31, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Currently, we don't pick up removable media (USB drives) or storage

> devices connected via plug-in cards. Take the sledge hammer approach

> for now.

>

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>


Tested-by: Ryan Harkin <ryan.harkin@linaro.org>

Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>


> ---

>  ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 7 +++++++

>  1 file changed, 7 insertions(+)

>

> diff --git a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c

> index e27e6d6..ceb4f07 100644

> --- a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c

> +++ b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c

> @@ -352,6 +352,13 @@ PlatformBdsPolicyBehavior (

>    // Show the splash screen.

>    //

>    EnableQuietBoot (PcdGetPtr (PcdLogoFile));

> +

> +  //

> +  // Connect _all_ devices, to pick up plug-in and removable devices

> +  // TODO: do this more cleanly, permitting faster boot times when boot config

> +  //       is known

> +  //

> +  BdsLibConnectAll ();

>  }

>

>  /**

> --

> 2.1.4

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Feb. 24, 2016, 10:35 a.m. UTC | #2
On 24 February 2016 at 11:34, Ryan Harkin <ryan.harkin@linaro.org> wrote:
> On 24 February 2016 at 10:31, Leif Lindholm <leif.lindholm@linaro.org> wrote:

>> Currently, we don't pick up removable media (USB drives) or storage

>> devices connected via plug-in cards. Take the sledge hammer approach

>> for now.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

>

> Tested-by: Ryan Harkin <ryan.harkin@linaro.org>

> Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>

>


Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


>> ---

>>  ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 7 +++++++

>>  1 file changed, 7 insertions(+)

>>

>> diff --git a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c

>> index e27e6d6..ceb4f07 100644

>> --- a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c

>> +++ b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c

>> @@ -352,6 +352,13 @@ PlatformBdsPolicyBehavior (

>>    // Show the splash screen.

>>    //

>>    EnableQuietBoot (PcdGetPtr (PcdLogoFile));

>> +

>> +  //

>> +  // Connect _all_ devices, to pick up plug-in and removable devices

>> +  // TODO: do this more cleanly, permitting faster boot times when boot config

>> +  //       is known

>> +  //

>> +  BdsLibConnectAll ();

>>  }

>>

>>  /**

>> --

>> 2.1.4

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
index e27e6d6..ceb4f07 100644
--- a/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
+++ b/ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c
@@ -352,6 +352,13 @@  PlatformBdsPolicyBehavior (
   // Show the splash screen.
   //
   EnableQuietBoot (PcdGetPtr (PcdLogoFile));
+
+  //
+  // Connect _all_ devices, to pick up plug-in and removable devices
+  // TODO: do this more cleanly, permitting faster boot times when boot config
+  //       is known
+  //
+  BdsLibConnectAll ();
 }
 
 /**