| Message ID | 20221206114609.2006175-5-yangyingliang@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | libertas/libertas_tf: don't call kfree_skb() under spin_lock_irqsave() | expand |
Hi, thank you for your information. On our website you can find email addresses of companies and people. https://www.skymem.info In short, it’s like Google for emails. Best regards, Robert, Skymem team On Tue, Dec 6, 2022 at 12:49 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > > It is not allowed to call kfree_skb() from hardware interrupt > context or with interrupts being disabled. So replace kfree_skb() > with dev_kfree_skb_irq() under spin_lock_irqsave(). > > Fixes: f52b041aed77 ("libertas: Add spinlock to avoid race condition") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/wireless/marvell/libertas/cmdresp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/net/wireless/marvell/libertas/cmdresp.c > index cb515c5584c1..74cb7551f427 100644 > --- a/drivers/net/wireless/marvell/libertas/cmdresp.c > +++ b/drivers/net/wireless/marvell/libertas/cmdresp.c > @@ -48,7 +48,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv, > > /* Free Tx and Rx packets */ > spin_lock_irqsave(&priv->driver_lock, flags); > - kfree_skb(priv->currenttxskb); > + dev_kfree_skb_irq(priv->currenttxskb); > priv->currenttxskb = NULL; > priv->tx_pending_len = 0; > spin_unlock_irqrestore(&priv->driver_lock, flags); > -- > 2.25.1 > > > _______________________________________________ > libertas-dev mailing list > libertas-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/libertas-dev
diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/net/wireless/marvell/libertas/cmdresp.c index cb515c5584c1..74cb7551f427 100644 --- a/drivers/net/wireless/marvell/libertas/cmdresp.c +++ b/drivers/net/wireless/marvell/libertas/cmdresp.c @@ -48,7 +48,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv, /* Free Tx and Rx packets */ spin_lock_irqsave(&priv->driver_lock, flags); - kfree_skb(priv->currenttxskb); + dev_kfree_skb_irq(priv->currenttxskb); priv->currenttxskb = NULL; priv->tx_pending_len = 0; spin_unlock_irqrestore(&priv->driver_lock, flags);
It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave(). Fixes: f52b041aed77 ("libertas: Add spinlock to avoid race condition") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/wireless/marvell/libertas/cmdresp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)