| Message ID | 20221207150008.111743-3-yangyingliang@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | libertas/libertas_tf: don't call kfree_skb() under spin_lock_irqsave() | expand |
Hi, thank you for your information. On our website you can find email addresses of companies and people. https://www.skymem.info In short, it’s like Google for emails. Best regards, Robert, Skymem team On Wed, Dec 7, 2022 at 4:04 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > > It is not allowed to call kfree_skb() from hardware interrupt > context or with interrupts being disabled. So replace kfree_skb() > with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile > tested only. > > Fixes: a3128feef6d5 ("libertas: use irqsave() in USB's complete callback") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/wireless/marvell/libertas/if_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c > index 32fdc4150b60..2240b4db8c03 100644 > --- a/drivers/net/wireless/marvell/libertas/if_usb.c > +++ b/drivers/net/wireless/marvell/libertas/if_usb.c > @@ -637,7 +637,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff, > priv->resp_len[i] = (recvlength - MESSAGE_HEADER_LEN); > memcpy(priv->resp_buf[i], recvbuff + MESSAGE_HEADER_LEN, > priv->resp_len[i]); > - kfree_skb(skb); > + dev_kfree_skb_irq(skb); > lbs_notify_command_response(priv, i); > > spin_unlock_irqrestore(&priv->driver_lock, flags); > -- > 2.25.1 > > > _______________________________________________ > libertas-dev mailing list > libertas-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/libertas-dev
diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c index 32fdc4150b60..2240b4db8c03 100644 --- a/drivers/net/wireless/marvell/libertas/if_usb.c +++ b/drivers/net/wireless/marvell/libertas/if_usb.c @@ -637,7 +637,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff, priv->resp_len[i] = (recvlength - MESSAGE_HEADER_LEN); memcpy(priv->resp_buf[i], recvbuff + MESSAGE_HEADER_LEN, priv->resp_len[i]); - kfree_skb(skb); + dev_kfree_skb_irq(skb); lbs_notify_command_response(priv, i); spin_unlock_irqrestore(&priv->driver_lock, flags);
It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile tested only. Fixes: a3128feef6d5 ("libertas: use irqsave() in USB's complete callback") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/wireless/marvell/libertas/if_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)