diff mbox

arm64: efi: add missing frame pointer assignment

Message ID 1457022692-14043-1-git-send-email-ard.biesheuvel@linaro.org
State Accepted
Commit cd1b76bb73d0f735cc9aa076c121fd172752445b
Headers show

Commit Message

Ard Biesheuvel March 3, 2016, 4:31 p.m. UTC
The prologue of the EFI entry point pushes x29 and x30 onto the stack but
fails to create the stack frame correctly by omitting the assignment of x29
to the new value of the stack pointer. So fix that.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 arch/arm64/kernel/efi-entry.S | 1 +
 1 file changed, 1 insertion(+)

-- 
2.5.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Comments

Catalin Marinas March 4, 2016, 6:12 p.m. UTC | #1
On Thu, Mar 03, 2016 at 05:31:32PM +0100, Ard Biesheuvel wrote:
> The prologue of the EFI entry point pushes x29 and x30 onto the stack but

> fails to create the stack frame correctly by omitting the assignment of x29

> to the new value of the stack pointer. So fix that.

> 

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  arch/arm64/kernel/efi-entry.S | 1 +

>  1 file changed, 1 insertion(+)


Applied. Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/arch/arm64/kernel/efi-entry.S b/arch/arm64/kernel/efi-entry.S
index 936022f0655e..e88c064b845c 100644
--- a/arch/arm64/kernel/efi-entry.S
+++ b/arch/arm64/kernel/efi-entry.S
@@ -35,6 +35,7 @@  ENTRY(entry)
 	 * for image_addr variable passed to efi_entry().
 	 */
 	stp	x29, x30, [sp, #-32]!
+	mov	x29, sp
 
 	/*
 	 * Call efi_entry to do the real work.