diff mbox series

[v2,2/9] dt-bindings: interrupt-controller: irqc-rzg2l: Drop RZG2L_NMI macro

Message ID 20221221000242.340202-3-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series Add IRQC support to RZ/G2UL SoC | expand

Commit Message

Lad, Prabhakar Dec. 21, 2022, 12:02 a.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

NMI interrupt is not an external interrupt as compared to IRQ0-7 and
TINT0-31 on RZ/G2L SoC, so there is no need for RZG2L_NMI macro.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1 -> v2
* New patch
---
 include/dt-bindings/interrupt-controller/irqc-rzg2l.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Krzysztof Kozlowski Dec. 29, 2022, 8:46 a.m. UTC | #1 
On 21/12/2022 01:02, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> NMI interrupt is not an external interrupt as compared to IRQ0-7 and
> TINT0-31 on RZ/G2L SoC, so there is no need for RZG2L_NMI macro.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1 -> v2


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Geert Uytterhoeven Jan. 3, 2023, 8:43 a.m. UTC | #2 
On Thu, Dec 29, 2022 at 9:46 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 21/12/2022 01:02, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > NMI interrupt is not an external interrupt as compared to IRQ0-7 and
> > TINT0-31 on RZ/G2L SoC, so there is no need for RZG2L_NMI macro.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v1 -> v2
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Given
https://lore.kernel.org/all/CA+V-a8vb-PfzMWX=ndF8nsyYVbkfYBkAQZ-UoS9zpQPndL871Q@mail.gmail.com
I think this patch is planned to be dropped, too?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Lad, Prabhakar Jan. 3, 2023, 10:33 a.m. UTC | #3 
Hi Geert,

On Tue, Jan 3, 2023 at 8:43 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Thu, Dec 29, 2022 at 9:46 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 21/12/2022 01:02, Prabhakar wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > NMI interrupt is not an external interrupt as compared to IRQ0-7 and
> > > TINT0-31 on RZ/G2L SoC, so there is no need for RZG2L_NMI macro.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > ---
> > > v1 -> v2
> >
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Given
> https://lore.kernel.org/all/CA+V-a8vb-PfzMWX=ndF8nsyYVbkfYBkAQZ-UoS9zpQPndL871Q@mail.gmail.com
> I think this patch is planned to be dropped, too?
>
Yes that's correct (and I have dropped in the v3).

Cheers,
Prabhakar
diff mbox series

Patch

diff --git a/include/dt-bindings/interrupt-controller/irqc-rzg2l.h b/include/dt-bindings/interrupt-controller/irqc-rzg2l.h
index 34ce778885a1..dd2da795208d 100644
--- a/include/dt-bindings/interrupt-controller/irqc-rzg2l.h
+++ b/include/dt-bindings/interrupt-controller/irqc-rzg2l.h
@@ -9,9 +9,6 @@ 
 #ifndef __DT_BINDINGS_IRQC_RZG2L_H
 #define __DT_BINDINGS_IRQC_RZG2L_H
 
-/* NMI maps to SPI0 */
-#define RZG2L_NMI	0
-
 /* IRQ0-7 map to SPI1-8 */
 #define RZG2L_IRQ0	1
 #define RZG2L_IRQ1	2