diff mbox

[edk2] NetworkPkg: HttpBootDxe: fix gcc build failure

Message ID 1457347371-18229-1-git-send-email-lersek@redhat.com
State Accepted
Commit 8244e1977689df34898e20dac83f736c3f3e0e90
Headers show

Commit Message

Laszlo Ersek March 7, 2016, 10:42 a.m. UTC 
Commit fa848a404894 ("NetworkPkg: Add URI configuration form to HTTP boot
driver") causes the build to fail with gcc:

> NetworkPkg/HttpBootDxe/HttpBootConfig.c: In function

>                                          'HttpBootAddBootOption':

> NetworkPkg/HttpBootDxe/HttpBootConfig.c:148:14:

> error: passing argument 3 of 'GetVariable2' from incompatible pointer

>        type [-Werror]

>               );

>               ^

> In file included from NetworkPkg/HttpBootDxe/HttpBootDxe.h:31:0,

>                  from NetworkPkg/HttpBootDxe/HttpBootConfig.c:15:

> MdePkg/Include/Library/UefiLib.h:708:1: note: expected 'void **' but

>                                         argument is of type 'CHAR16 **'

>  GetVariable2 (

>  ^

> cc1: all warnings being treated as errors


Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>

---
 NetworkPkg/HttpBootDxe/HttpBootConfig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.3.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
index db14da06d5cb..597192349d6b 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
@@ -143,7 +143,7 @@  HttpBootAddBootOption (
   Status = GetVariable2 (
              L"BootOrder",
              &gEfiGlobalVariableGuid,
-             &CurrentOrder,
+             (VOID **)&CurrentOrder,
              &Length 
              );
   if (EFI_ERROR (Status) && Status != EFI_NOT_FOUND) {