| Message ID | 20230111074528.29354-9-roger.lu@mediatek.com |
|---|---|
| State | New |
| Headers | show |
| Series | Enahance SVS's robustness | expand |
On 11/01/2023 08:45, Roger Lu wrote: > From: Matthias Brugger <matthias.bgg@gmail.com> > > We only ever call the SoC specific probe function from > svs_platform_probe. No need to carry that function in a global > datastructure around. > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Roger Lu <roger.lu@mediatek.com> Applied, thanks! > --- > drivers/soc/mediatek/mtk-svs.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index 70ca9c9acae0..41c0ac5ed8d3 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -321,7 +321,6 @@ static const u32 svs_regs_v2[] = { > * @banks: svs banks that svs platform supports > * @rst: svs platform reset control > * @efuse_parsing: svs platform efuse parsing function pointer > - * @probe: svs platform probe function pointer > * @efuse_max: total number of svs efuse > * @tefuse_max: total number of thermal efuse > * @regs: svs platform registers map > @@ -339,7 +338,6 @@ struct svs_platform { > struct svs_bank *banks; > struct reset_control *rst; > bool (*efuse_parsing)(struct svs_platform *svsp); > - int (*probe)(struct svs_platform *svsp); > size_t efuse_max; > size_t tefuse_max; > const u32 *regs; > @@ -2409,11 +2407,10 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) > svsp->name = svsp_data->name; > svsp->banks = svsp_data->banks; > svsp->efuse_parsing = svsp_data->efuse_parsing; > - svsp->probe = svsp_data->probe; > svsp->regs = svsp_data->regs; > svsp->bank_max = svsp_data->bank_max; > > - ret = svsp->probe(svsp); > + ret = svsp_data->probe(svsp); > if (ret) > return ERR_PTR(ret); >
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 70ca9c9acae0..41c0ac5ed8d3 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -321,7 +321,6 @@ static const u32 svs_regs_v2[] = { * @banks: svs banks that svs platform supports * @rst: svs platform reset control * @efuse_parsing: svs platform efuse parsing function pointer - * @probe: svs platform probe function pointer * @efuse_max: total number of svs efuse * @tefuse_max: total number of thermal efuse * @regs: svs platform registers map @@ -339,7 +338,6 @@ struct svs_platform { struct svs_bank *banks; struct reset_control *rst; bool (*efuse_parsing)(struct svs_platform *svsp); - int (*probe)(struct svs_platform *svsp); size_t efuse_max; size_t tefuse_max; const u32 *regs; @@ -2409,11 +2407,10 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) svsp->name = svsp_data->name; svsp->banks = svsp_data->banks; svsp->efuse_parsing = svsp_data->efuse_parsing; - svsp->probe = svsp_data->probe; svsp->regs = svsp_data->regs; svsp->bank_max = svsp_data->bank_max; - ret = svsp->probe(svsp); + ret = svsp_data->probe(svsp); if (ret) return ERR_PTR(ret);