diff mbox

[Branch,~linaro-validation/lava-scheduler/trunk] Rev 121: make submit_job give slightly more useful permission errors

Message ID 20120130205817.14401.98337.launchpad@ackee.canonical.com
State Accepted
Headers show

Commit Message

Michael-Doyle Hudson Jan. 30, 2012, 8:58 p.m. UTC 
Merge authors:
  Michael Hudson-Doyle (mwhudson)
Related merge proposals:
  https://code.launchpad.net/~mwhudson/lava-scheduler/more-helpful-401s-bug-917390/+merge/90036
  proposed by: Michael Hudson-Doyle (mwhudson)
  review: Approve - Zygmunt Krynicki (zkrynicki)
------------------------------------------------------------
revno: 121 [merge]
committer: Michael Hudson-Doyle <michael.hudson@linaro.org>
branch nick: trunk
timestamp: Tue 2012-01-31 09:56:39 +1300
message:
  make submit_job give slightly more useful permission errors
modified:
  lava_scheduler_app/api.py


--
lp:lava-scheduler
https://code.launchpad.net/~linaro-validation/lava-scheduler/trunk

You are subscribed to branch lp:lava-scheduler.
To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-scheduler/trunk/+edit-subscription
diff mbox

Patch

=== modified file 'lava_scheduler_app/api.py'
--- lava_scheduler_app/api.py	2011-10-19 21:05:42 +0000
+++ lava_scheduler_app/api.py	2012-01-25 02:42:58 +0000
@@ -16,9 +16,14 @@ 
 
     def submit_job(self, job_data):
         if not self.user:
-            raise xmlrpclib.Fault(401, "Authentication required.")
+            raise xmlrpclib.Fault(
+                401, "Authentication with user and token required for this "
+                "API.")
         if not self.user.has_perm('lava_scheduler_app.add_testjob'):
-            raise xmlrpclib.Fault(403, "Permission denied.")
+            raise xmlrpclib.Fault(
+                403, "Permission denied.  User %r does not have the "
+                "'lava_scheduler_app.add_testjob' permission.  Contact "
+                "the administrators." % self.user.username)
         try:
             job = TestJob.from_json_and_user(job_data, self.user)
         except JSONDecodeError as e: