| Message ID | 20230202153723.1554935-1-stefan@datenfreihafen.org |
|---|---|
| State | New |
| Headers | show |
| Series | pull-request: ieee802154-next 2023-02-02 | expand |
On Thu, 2 Feb 2023 16:37:23 +0100 Stefan Schmidt wrote: > Miquel Raynal build upon his earlier work and introduced two new > features into the ieee802154 stack. Beaconing to announce existing > PAN's and passive scanning to discover the beacons and associated > PAN's. The matching changes to the userspace configuration tool > have been posted as well and will be released when 6.3 is ready. I left some comments on the netlink part, sorry for not looking at it earlier.
Hi Jakub, kuba@kernel.org wrote on Fri, 3 Feb 2023 20:21:47 -0800: > On Thu, 2 Feb 2023 16:37:23 +0100 Stefan Schmidt wrote: > > Miquel Raynal build upon his earlier work and introduced two new > > features into the ieee802154 stack. Beaconing to announce existing > > PAN's and passive scanning to discover the beacons and associated > > PAN's. The matching changes to the userspace configuration tool > > have been posted as well and will be released when 6.3 is ready. > > I left some comments on the netlink part, sorry for not looking > at it earlier. As I'm not extremely comfortable with all the netlink conventions I might have squeezed "important" checks, I will try to make the code more robust as you suggested. I will do my best to address these, probably next week, do you prefer to wait for these additional changes to apply on top of wpan-next and Stefan to rush with another PR before -rc8? Or do you accept to pull the changes now and to receive a couple of patches in a following fixes PR? (the latter would be the best IMHO, but it's of course up to you). Thanks, Miquèl
On Sat, 4 Feb 2023 12:46:56 +0100 Miquel Raynal wrote: > > I left some comments on the netlink part, sorry for not looking > > at it earlier. > > As I'm not extremely comfortable with all the netlink conventions I > might have squeezed "important" checks, I will try to make the code > more robust as you suggested. > > I will do my best to address these, probably next week, do you prefer > to wait for these additional changes to apply on top of wpan-next and > Stefan to rush with another PR before -rc8? Or do you accept to pull the > changes now and to receive a couple of patches in a following fixes > PR? (the latter would be the best IMHO, but it's of course up to you). I have a slight preference to wait with the pulling until the fixes/ refactoring arrives.
Hello Jakub. On 04.02.23 20:18, Jakub Kicinski wrote: > On Sat, 4 Feb 2023 12:46:56 +0100 Miquel Raynal wrote: >>> I left some comments on the netlink part, sorry for not looking >>> at it earlier. >> >> As I'm not extremely comfortable with all the netlink conventions I >> might have squeezed "important" checks, I will try to make the code >> more robust as you suggested. >> >> I will do my best to address these, probably next week, do you prefer >> to wait for these additional changes to apply on top of wpan-next and >> Stefan to rush with another PR before -rc8? Or do you accept to pull the >> changes now and to receive a couple of patches in a following fixes >> PR? (the latter would be the best IMHO, but it's of course up to you). > > I have a slight preference to wait with the pulling until the fixes/ > refactoring arrives. The new pull request as v2 has just been posted. regards Stefan Schmidt
Hello Dave, Jakub. An update from ieee802154 for *net-next* Miquel Raynal build upon his earlier work and introduced two new features into the ieee802154 stack. Beaconing to announce existing PAN's and passive scanning to discover the beacons and associated PAN's. The matching changes to the userspace configuration tool have been posted as well and will be released when 6.3 is ready. Arnd Bergmann and Dmitry Torokhov worked on converting the at86rf230 and cc2520 drivers away from the unused platform_data usage and towards the new gpiod API. (I had to add a revert as Dmitry found a regression on an already pushed tree on my side). regards Stefan Schmidt The following changes since commit d8b879c00f69a22738f6bb7198e763cfcc6b68f8: Merge branch 'net-ethernet-ti-am65-cpsw-fix-set-channel-operation' (2022-12-07 20:17:35 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan-next.git tags/ieee802154-for-net-next-2023-02-02 for you to fetch changes up to 6130543654e0e5a79485ed8538c0bf2259fe7431: ieee802154: at86rf230: switch to using gpiod API (2023-02-01 21:30:09 +0100) ---------------------------------------------------------------- Arnd Bergmann (2): at86rf230: convert to gpio descriptors cc2520: move to gpio descriptors Dmitry Torokhov (2): ieee802154: at86rf230: drop support for platform data ieee802154: at86rf230: switch to using gpiod API Miquel Raynal (9): ieee802154: Add support for user scanning requests ieee802154: Define a beacon frame header ieee802154: Introduce a helper to validate a channel mac802154: Prepare forcing specific symbol duration mac802154: Add MLME Tx locked helpers mac802154: Handle passive scanning ieee802154: Add support for user beaconing requests mac802154: Handle basic beaconing mac802154: Avoid superfluous endianness handling Stefan Schmidt (1): Revert "at86rf230: convert to gpio descriptors" MAINTAINERS | 1 - drivers/net/ieee802154/at86rf230.c | 90 +++----- drivers/net/ieee802154/cc2520.c | 136 ++++-------- include/linux/ieee802154.h | 7 + include/linux/spi/at86rf230.h | 20 -- include/linux/spi/cc2520.h | 21 -- include/net/cfg802154.h | 78 ++++++- include/net/ieee802154_netdev.h | 52 +++++ include/net/nl802154.h | 61 ++++++ net/ieee802154/header_ops.c | 24 ++ net/ieee802154/nl802154.c | 316 +++++++++++++++++++++++++- net/ieee802154/nl802154.h | 4 + net/ieee802154/rdev-ops.h | 56 +++++ net/ieee802154/trace.h | 61 ++++++ net/mac802154/Makefile | 2 +- net/mac802154/cfg.c | 60 ++++- net/mac802154/ieee802154_i.h | 61 +++++- net/mac802154/iface.c | 6 + net/mac802154/llsec.c | 5 +- net/mac802154/main.c | 37 +++- net/mac802154/rx.c | 36 ++- net/mac802154/scan.c | 439 +++++++++++++++++++++++++++++++++++++ net/mac802154/tx.c | 42 ++-- 23 files changed, 1386 insertions(+), 229 deletions(-) delete mode 100644 include/linux/spi/at86rf230.h delete mode 100644 include/linux/spi/cc2520.h create mode 100644 net/mac802154/scan.c