| Message ID | 20230214161211.306462-1-robert.marko@sartura.hr |
|---|---|
| State | Accepted |
| Commit | 131731c44f2cea44135e93bfb0a2920829910625 |
| Headers | show |
| Series | [1/4] ARM: dts: qcom: ipq4018-ap120c-ac: setup serial console | expand |
On 14.02.2023 17:12, Robert Marko wrote: > Add the required alias and stdout property so that kernel can setup > the console based off DTS and not have to set it in the cmdline. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > index a5a6f3ebb2749..38efd45433da5 100644 > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > @@ -8,6 +8,14 @@ / { > model = "ALFA Network AP120C-AC"; > compatible = "alfa-network,ap120c-ac", "qcom,ipq4018"; > > + aliases { > + serial0 = &blsp1_uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > keys { > compatible = "gpio-keys"; >
On 14.02.2023 17:12, Robert Marko wrote: > Align USB power GPIO hog node to DT schema. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > --- Unless you submitted a separate patch for this, I only see hog being allowed in 845 TLMM. Konrad > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > index 38efd45433da5..cd2a32d0d5548 100644 > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > @@ -76,7 +76,7 @@ mux_cs { > }; > }; > > - usb-power { > + usb-power-hog { > line-name = "USB-power"; > gpios = <1 GPIO_ACTIVE_HIGH>; > gpio-hog;
On Thu, Feb 16, 2023 at 11:48 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 14.02.2023 17:12, Robert Marko wrote: > > Align USB power GPIO hog node to DT schema. > > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > --- > Unless you submitted a separate patch for this, I only see > hog being allowed in 845 TLMM. No, cause there is a gpio-hog schema in dtschema and I did not even look into the pinctrl bindings and dtbs_check is not throwing a warning. I dont really see a point further allowing it in pinctrl bindings. Regards, Robert > > Konrad > > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > > index 38efd45433da5..cd2a32d0d5548 100644 > > --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > > +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi > > @@ -76,7 +76,7 @@ mux_cs { > > }; > > }; > > > > - usb-power { > > + usb-power-hog { > > line-name = "USB-power"; > > gpios = <1 GPIO_ACTIVE_HIGH>; > > gpio-hog;
diff --git a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi index a5a6f3ebb2749..38efd45433da5 100644 --- a/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi +++ b/arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi @@ -8,6 +8,14 @@ / { model = "ALFA Network AP120C-AC"; compatible = "alfa-network,ap120c-ac", "qcom,ipq4018"; + aliases { + serial0 = &blsp1_uart1; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + keys { compatible = "gpio-keys";
Add the required alias and stdout property so that kernel can setup the console based off DTS and not have to set it in the cmdline. Signed-off-by: Robert Marko <robert.marko@sartura.hr> --- arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)