| Message ID | 20230216013230.22978-12-ansuelsmth@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Adds support for PHY LEDs with offload triggers | expand |
On Fri, Feb 17, 2023 at 05:03:46PM -0600, Rob Herring wrote: > On Thu, Feb 16, 2023 at 02:32:28AM +0100, Christian Marangi wrote: > > Document the netdev trigger that makes the LED blink or turn on based on > > switch/phy events or an attached network interface. > > NAK. What is netdev? But netdev is a trigger, nothing new. Actually it was never documented. Is the linux,default-trigger getting deprecated? > > Don't add new linux,default-trigger entries either. We have better ways > to define trigger sources, namely 'trigger-sources'. > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > Documentation/devicetree/bindings/leds/common.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > > index d34bb58c0037..6e016415a4d8 100644 > > --- a/Documentation/devicetree/bindings/leds/common.yaml > > +++ b/Documentation/devicetree/bindings/leds/common.yaml > > @@ -98,6 +98,8 @@ properties: > > # LED alters the brightness for the specified duration with one software > > # timer (requires "led-pattern" property) > > - pattern > > + # LED blink and turns on based on netdev events > > + - netdev > > - pattern: "^cpu[0-9]*$" > > - pattern: "^hci[0-9]+-power$" > > # LED is triggered by Bluetooth activity > > -- > > 2.38.1 > >
On Thu, Feb 16, 2023 at 02:32:28AM +0100, Christian Marangi wrote: > Document the netdev trigger that makes the LED blink or turn on based on > switch/phy events or an attached network interface. NAK. What is netdev? Don't add new linux,default-trigger entries either. We have better ways to define trigger sources, namely 'trigger-sources'. > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/leds/common.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > index d34bb58c0037..6e016415a4d8 100644 > --- a/Documentation/devicetree/bindings/leds/common.yaml > +++ b/Documentation/devicetree/bindings/leds/common.yaml > @@ -98,6 +98,8 @@ properties: > # LED alters the brightness for the specified duration with one software > # timer (requires "led-pattern" property) > - pattern > + # LED blink and turns on based on netdev events > + - netdev > - pattern: "^cpu[0-9]*$" > - pattern: "^hci[0-9]+-power$" > # LED is triggered by Bluetooth activity > -- > 2.38.1 >
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index d34bb58c0037..6e016415a4d8 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -98,6 +98,8 @@ properties: # LED alters the brightness for the specified duration with one software # timer (requires "led-pattern" property) - pattern + # LED blink and turns on based on netdev events + - netdev - pattern: "^cpu[0-9]*$" - pattern: "^hci[0-9]+-power$" # LED is triggered by Bluetooth activity
Document the netdev trigger that makes the LED blink or turn on based on switch/phy events or an attached network interface. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- Documentation/devicetree/bindings/leds/common.yaml | 2 ++ 1 file changed, 2 insertions(+)