| Message ID | 20230220181205.1577283-1-hj.tedd.an@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ,v2] configure: Check ell path | expand |
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 20 Feb 2023 10:12:05 -0800 you wrote: > From: Tedd Ho-Jeong An <tedd.an@intel.com> > > If the 'enable-external-ell' is not specified in the configure parameter, > the build system assumes that the ELL source is located same level where > the bluez source is cloned. But the configure doens't check the folder > and user will get the build error while building the source. > > [...] Here is the summary with links: - [BlueZ,v2] configure: Check ell path https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1106b28be85a You are awesome, thank you!
diff --git a/configure.ac b/configure.ac index f9f0faf57..515cdf146 100644 --- a/configure.ac +++ b/configure.ac @@ -289,6 +289,11 @@ if (test "${enable_external_ell}" = "yes"); then AC_SUBST(ELL_CFLAGS) AC_SUBST(ELL_LIBS) fi +if (test "${enable_external_ell}" != "yes"); then + AC_CHECK_FILE(${srcdir}/ell/ell.h, dummy=yes, + AC_CHECK_FILE(${srcdir}/../ell/ell/ell.h, dummy=yes, + AC_MSG_ERROR(ELL source is required or use --enable-external-ell))) +fi AM_CONDITIONAL(EXTERNAL_ELL, test "${enable_external_ell}" = "yes" || (test "${enable_btpclient}" != "yes" && test "${enable_mesh}" != "yes"))
From: Tedd Ho-Jeong An <tedd.an@intel.com> If the 'enable-external-ell' is not specified in the configure parameter, the build system assumes that the ELL source is located same level where the bluez source is cloned. But the configure doens't check the folder and user will get the build error while building the source. This patch checks if the ELL source path if the 'enable-external-ell' flag is not set and throws an error if the ELL doesn't exist. --- configure.ac | 5 +++++ 1 file changed, 5 insertions(+)