diff mbox

[2/3] qemu: Clarify usage of DomainObjIsActive for PMSuspended

Message ID e783bcaa49ab706949088076fc5b524e5017b68a.1460728797.git.crobinso@redhat.com
State New
Headers show

Commit Message

Cole Robinson April 15, 2016, 2 p.m. UTC 
---
 src/qemu/qemu_driver.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.7.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9a3d46b..f8dfa27 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -18237,6 +18237,9 @@  qemuDomainPMSuspendForDuration(virDomainPtr dom,
     if (virDomainPMSuspendForDurationEnsureACL(dom->conn, vm->def) < 0)
         goto cleanup;
 
+    /* We also perform this check further down after grabbing the
+       job lock, but do it here too so we can throw an error for
+       an invalid config, before trying to talk to the guest agent */
     if (!virDomainObjIsActive(vm)) {
         virReportError(VIR_ERR_OPERATION_INVALID,
                        "%s", _("domain is not running"));