| Message ID | 20230307170046.28917-11-ansuelsmth@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net-next,01/11] net: dsa: qca8k: add LEDs basic support | expand |
On 08/03/2023 12:00, Krzysztof Kozlowski wrote: > On 07/03/2023 18:00, Christian Marangi wrote: >> Document support for LEDs node in phy and add an example for it. >> PHY LED will have to match led pattern and should be treated as a >> generic led. >> >> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> >> --- > > Also missing changelog, history, tags, anything. This was already v8. > > Also, I have doubts that your patchset is fully bisectable. Are you sure > of this? OK, so the leds in previous patch are not for phy but for port, so it is properly bisectable. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml index 1327b81f15a2..0ec8ef6b0d8a 100644 --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml @@ -197,6 +197,13 @@ properties: PHY's that have configurable TX internal delays. If this property is present then the PHY applies the TX delay. + leds: + type: object + + patternProperties: + '^led(@[a-f0-9]+)?$': + $ref: /schemas/leds/common.yaml# + required: - reg @@ -204,6 +211,8 @@ additionalProperties: true examples: - | + #include <dt-bindings/leds/common.h> + ethernet { #address-cells = <1>; #size-cells = <0>; @@ -219,5 +228,18 @@ examples: reset-gpios = <&gpio1 4 1>; reset-assert-us = <1000>; reset-deassert-us = <2000>; + + leds { + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + color = <LED_COLOR_ID_WHITE>; + function = LED_FUNCTION_LAN; + function-enumerator = <1>; + default-state = "keep"; + }; + }; }; };
Document support for LEDs node in phy and add an example for it. PHY LED will have to match led pattern and should be treated as a generic led. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> --- .../devicetree/bindings/net/ethernet-phy.yaml | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)