| Message ID | 20230315120327.958413-2-neeraj.sanjaykale@nxp.com |
|---|---|
| State | Accepted |
| Commit | d227f286d259b29908e984da78fdfe033c6a1c56 |
| Headers | show |
| Series | Add support for NXP bluetooth chipsets | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=730293 ---Test result--- Test Summary: CheckPatch PASS 4.91 seconds GitLint FAIL 1.44 seconds SubjectPrefix FAIL 0.65 seconds BuildKernel PASS 31.18 seconds CheckAllWarning PASS 34.17 seconds CheckSparse PASS 38.80 seconds CheckSmatch PASS 108.13 seconds BuildKernel32 PASS 30.18 seconds TestRunnerSetup PASS 436.06 seconds TestRunner_l2cap-tester PASS 16.78 seconds TestRunner_iso-tester PASS 16.88 seconds TestRunner_bnep-tester PASS 5.33 seconds TestRunner_mgmt-tester PASS 108.04 seconds TestRunner_rfcomm-tester PASS 8.62 seconds TestRunner_sco-tester PASS 7.86 seconds TestRunner_ioctl-tester PASS 9.18 seconds TestRunner_mesh-tester PASS 6.72 seconds TestRunner_smp-tester PASS 7.78 seconds TestRunner_userchan-tester PASS 5.59 seconds IncrementalBuild PASS 43.18 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [v12,3/4] dt-bindings: net: bluetooth: Add NXP bluetooth support WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 20: B1 Line exceeds max length (87>80): " create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml" ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject "Bluetooth: " prefix is not specified in the subject "Bluetooth: " prefix is not specified in the subject --- Regards, Linux Bluetooth
On Wed, Mar 15, 2023 at 05:33:23PM +0530, Neeraj Sanjay Kale wrote: > This replaces all instances of ENOTSUPP with EOPNOTSUPP since ENOTSUPP > is not a standard error code. This will help maintain consistency in > error codes when new serdev API's are added. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > --- > v11: Replace all instances of ENOTSUPP with EOPNOTSUPP. (Simon Horman) There may be a policy or issue here, I defer to the maintainer on that. But from my PoV this looks good. Reviewed-by: Simon Horman <simon.horman@corigine.com> BTW, please consider waiting 24h between patch postings to allow review to take place.
diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index 0180e1e4e75d..d43aabd0cb76 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -366,7 +366,7 @@ int serdev_device_set_parity(struct serdev_device *serdev, struct serdev_controller *ctrl = serdev->ctrl; if (!ctrl || !ctrl->ops->set_parity) - return -ENOTSUPP; + return -EOPNOTSUPP; return ctrl->ops->set_parity(ctrl, parity); } @@ -388,7 +388,7 @@ int serdev_device_get_tiocm(struct serdev_device *serdev) struct serdev_controller *ctrl = serdev->ctrl; if (!ctrl || !ctrl->ops->get_tiocm) - return -ENOTSUPP; + return -EOPNOTSUPP; return ctrl->ops->get_tiocm(ctrl); } @@ -399,7 +399,7 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear) struct serdev_controller *ctrl = serdev->ctrl; if (!ctrl || !ctrl->ops->set_tiocm) - return -ENOTSUPP; + return -EOPNOTSUPP; return ctrl->ops->set_tiocm(ctrl, set, clear); } diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c index d367803e2044..f26ff82723f1 100644 --- a/drivers/tty/serdev/serdev-ttyport.c +++ b/drivers/tty/serdev/serdev-ttyport.c @@ -231,7 +231,7 @@ static int ttyport_get_tiocm(struct serdev_controller *ctrl) struct tty_struct *tty = serport->tty; if (!tty->ops->tiocmget) - return -ENOTSUPP; + return -EOPNOTSUPP; return tty->ops->tiocmget(tty); } @@ -242,7 +242,7 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u struct tty_struct *tty = serport->tty; if (!tty->ops->tiocmset) - return -ENOTSUPP; + return -EOPNOTSUPP; return tty->ops->tiocmset(tty, set, clear); } diff --git a/include/linux/serdev.h b/include/linux/serdev.h index 66f624fc618c..89b0a5af9be2 100644 --- a/include/linux/serdev.h +++ b/include/linux/serdev.h @@ -249,11 +249,11 @@ static inline int serdev_device_write_buf(struct serdev_device *serdev, static inline void serdev_device_wait_until_sent(struct serdev_device *sdev, long timeout) {} static inline int serdev_device_get_tiocm(struct serdev_device *serdev) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear) { - return -ENOTSUPP; + return -EOPNOTSUPP; } static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf, size_t count, unsigned long timeout)
This replaces all instances of ENOTSUPP with EOPNOTSUPP since ENOTSUPP is not a standard error code. This will help maintain consistency in error codes when new serdev API's are added. Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- v11: Replace all instances of ENOTSUPP with EOPNOTSUPP. (Simon Horman) --- drivers/tty/serdev/core.c | 6 +++--- drivers/tty/serdev/serdev-ttyport.c | 4 ++-- include/linux/serdev.h | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-)