diff mbox series

[04/10] accel/tcg: don't bother with ifdef for CPU_DUMP_CCOP

Message ID 20230320101035.2214196-5-alex.bennee@linaro.org
State New
Headers show
Series accel/tcg: refactor the cpu-exec loop | expand

Commit Message

Alex Bennée March 20, 2023, 10:10 a.m. UTC 
While only i386 dumps anything useful for the flag it could
potentially be used by others. Front ends that don't understand the
flag will ignore it anyway.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 accel/tcg/cpu-exec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Richard Henderson March 20, 2023, 4:16 p.m. UTC | #1 
On 3/20/23 03:10, Alex Bennée wrote:
> +                int flags = CPU_DUMP_CCOP;;

two ;

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~
Richard Henderson March 20, 2023, 4:17 p.m. UTC | #2 
On 3/20/23 03:10, Alex Bennée wrote:
> +                int flags = CPU_DUMP_CCOP;;

Actually, since you can't turn it off, we should just remove it and the test in i386.


r~
diff mbox series

Patch

diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 5e5906e199..f883be197f 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -309,14 +309,11 @@  static void log_cpu_exec(target_ulong pc, CPUState *cpu,
         if (qemu_loglevel_mask(CPU_LOG_TB_CPU)) {
             FILE *logfile = qemu_log_trylock();
             if (logfile) {
-                int flags = 0;
+                int flags = CPU_DUMP_CCOP;;
 
                 if (qemu_loglevel_mask(CPU_LOG_TB_FPU)) {
                     flags |= CPU_DUMP_FPU;
                 }
-#if defined(TARGET_I386)
-                flags |= CPU_DUMP_CCOP;
-#endif
                 cpu_dump_state(cpu, logfile, flags);
                 qemu_log_unlock(logfile);
             }