Message ID | 20230328040524.49278-1-inki.dae@samsung.com |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] exynos-drm-next | expand |
On Tue, Mar 28, 2023 at 01:05:24PM +0900, Inki Dae wrote: > Hi Dave and Daniel, > > Just one patch series that moves the existing Exynos DSI driver > to drm/bridge directory to support both SoCs family - Exynos > and I.MX - because same Exynos MIPI DSI ip can be used by the two > different SoC family. > > Of course, there are some concerns about this patch series because Exynos > and I.MX SoCs have different HW characteristic but use the same HW driver. > However, I believe that there should be no problem as Exynos and I.MX > developers have conducted tests and reviews enough for about a year > since last April. > > This would be the first case that we allow different vendor SoCs to use > same device driver at least in DRM world so we anticipate experiencing > and resolving new issues through ongoing maintenance, and ultimately, > the experiences gained here will undoubtedly be able to contribute > the development of the community as well. > > Please kindly let me know if there is any problem. > > Thanks, > Inki Dae > > The following changes since commit 46f28427f6f824b6cff06fa025a55350b7de454a: > > Merge tag 'drm-rcar-next-20230325' of git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into drm-next (2023-03-27 18:20:20 +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-drm-next-for-v6.4 Merged, but usually all drm bridge stuff goes through drm-misc, least so that there's some amount of collaboration and not so much inter-tree syncing. Please apply for drm-misc commit rights (at least a quick check shows no one from samsung) and land future bridge patches through that tree. Cheers, Daniel > > for you to fetch changes up to b2cfec52feb3bb737c4b65018ef4bfe9789e4be8: > > drm: bridge: samsung-dsim: Add i.MX8M Plus support (2023-03-28 09:05:41 +0900) > > ---------------------------------------------------------------- > A patch series for moving MIPI-DSI driver for Exynos DRM to drm/bridge > directory so that I.MX SoC family can also share the same device driver. > Samsung MIPI DSIM device is a common IP that can be used by Exynos and I.MX8M > Mini/Nano/Plus SoC. Regarding this, this patch series has added several > things below to existing MIPI DSI driver, > - Add exynos_dsi_type enum type to provide controller data from different > platforms. > - Add two pipeline detection ways support - existing Exynos DSI child node > and I.MX family of-graph port or ports. > - Consider component and bridged based DRM drivers. > - Add device tree binding support of I.MX family. > > ---------------------------------------------------------------- > Jagan Teki (14): > drm: exynos: dsi: Drop explicit call to bridge detach > drm: exynos: dsi: Lookup OF-graph or Child node devices > drm: exynos: dsi: Mark PHY as optional > drm: exynos: dsi: Add platform PLL_P (PMS_P) offset > drm: exynos: dsi: Introduce hw_type platform data > drm: exynos: dsi: Add atomic check > drm: exynos: dsi: Add input_bus_flags > drm: exynos: dsi: Add atomic_get_input_bus_fmts > drm: exynos: dsi: Consolidate component and bridge > drm: exynos: dsi: Add host helper for te_irq_handler > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > > Marek Szyprowski (1): > drm: exynos: dsi: Handle proper host initialization > > Marek Vasut (1): > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > .../bindings/display/exynos/exynos_dsim.txt | 2 + > MAINTAINERS | 9 + > drivers/gpu/drm/bridge/Kconfig | 12 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/samsung-dsim.c | 1967 ++++++++++++++++++++ > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1813 +----------------- > include/drm/bridge/samsung-dsim.h | 115 ++ > 8 files changed, 2191 insertions(+), 1729 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > create mode 100644 include/drm/bridge/samsung-dsim.h
> -----Original Message----- > From: Daniel Vetter <daniel@ffwll.ch> > Sent: Wednesday, March 29, 2023 2:31 AM > To: Inki Dae <inki.dae@samsung.com> > Cc: airlied@linux.ie; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; > linux-samsung-soc@vger.kernel.org > Subject: Re: [GIT PULL] exynos-drm-next > > On Tue, Mar 28, 2023 at 01:05:24PM +0900, Inki Dae wrote: > > Hi Dave and Daniel, > > > > Just one patch series that moves the existing Exynos DSI driver > > to drm/bridge directory to support both SoCs family - Exynos > > and I.MX - because same Exynos MIPI DSI ip can be used by the two > > different SoC family. > > > > Of course, there are some concerns about this patch series because > Exynos > > and I.MX SoCs have different HW characteristic but use the same HW > driver. > > However, I believe that there should be no problem as Exynos and I.MX > > developers have conducted tests and reviews enough for about a year > > since last April. > > > > This would be the first case that we allow different vendor SoCs to use > > same device driver at least in DRM world so we anticipate experiencing > > and resolving new issues through ongoing maintenance, and ultimately, > > the experiences gained here will undoubtedly be able to contribute > > the development of the community as well. > > > > Please kindly let me know if there is any problem. > > > > Thanks, > > Inki Dae > > > > The following changes since commit > 46f28427f6f824b6cff06fa025a55350b7de454a: > > > > Merge tag 'drm-rcar-next-20230325' of > git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into drm-next > (2023-03-27 18:20:20 +0200) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos > tags/exynos-drm-next-for-v6.4 > > Merged, but usually all drm bridge stuff goes through drm-misc, least so > that there's some amount of collaboration and not so much inter-tree > syncing. > > Please apply for drm-misc commit rights (at least a quick check shows no > one from samsung) and land future bridge patches through that tree. > > Cheers, Daniel I will apply for drm-misc commit rights. :) Thanks, Inki Dae > > > > > for you to fetch changes up to b2cfec52feb3bb737c4b65018ef4bfe9789e4be8: > > > > drm: bridge: samsung-dsim: Add i.MX8M Plus support (2023-03-28 09:05:41 > +0900) > > > > ---------------------------------------------------------------- > > A patch series for moving MIPI-DSI driver for Exynos DRM to drm/bridge > > directory so that I.MX SoC family can also share the same device driver. > > Samsung MIPI DSIM device is a common IP that can be used by Exynos and > I.MX8M > > Mini/Nano/Plus SoC. Regarding this, this patch series has added several > > things below to existing MIPI DSI driver, > > - Add exynos_dsi_type enum type to provide controller data from > different > > platforms. > > - Add two pipeline detection ways support - existing Exynos DSI child > node > > and I.MX family of-graph port or ports. > > - Consider component and bridged based DRM drivers. > > - Add device tree binding support of I.MX family. > > > > ---------------------------------------------------------------- > > Jagan Teki (14): > > drm: exynos: dsi: Drop explicit call to bridge detach > > drm: exynos: dsi: Lookup OF-graph or Child node devices > > drm: exynos: dsi: Mark PHY as optional > > drm: exynos: dsi: Add platform PLL_P (PMS_P) offset > > drm: exynos: dsi: Introduce hw_type platform data > > drm: exynos: dsi: Add atomic check > > drm: exynos: dsi: Add input_bus_flags > > drm: exynos: dsi: Add atomic_get_input_bus_fmts > > drm: exynos: dsi: Consolidate component and bridge > > drm: exynos: dsi: Add host helper for te_irq_handler > > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > > > > Marek Szyprowski (1): > > drm: exynos: dsi: Handle proper host initialization > > > > Marek Vasut (1): > > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > > > .../bindings/display/exynos/exynos_dsim.txt | 2 + > > MAINTAINERS | 9 + > > drivers/gpu/drm/bridge/Kconfig | 12 + > > drivers/gpu/drm/bridge/Makefile | 1 + > > drivers/gpu/drm/bridge/samsung-dsim.c | 1967 > ++++++++++++++++++++ > > drivers/gpu/drm/exynos/Kconfig | 1 + > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1813 +---------------- - > > include/drm/bridge/samsung-dsim.h | 115 ++ > > 8 files changed, 2191 insertions(+), 1729 deletions(-) > > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > > create mode 100644 include/drm/bridge/samsung-dsim.h > > -- > Daniel Vetter > Software Engineer, Intel Corporation > https://protect2.fireeye.com/v1/url?k=7fdd2b55-1e563e63-7fdca01a- > 74fe485cbff1-6c2178cc05019313&q=1&e=e4f34328-cc9e-48f9-80e0- > ec8c0c4246f2&u=http%3A%2F%2Fblog.ffwll.ch%2F
Hi Daniel, 2023년 3월 29일 (수) 오후 2:39, 대인기 <inki.dae@samsung.com>님이 작성: > > > > > -----Original Message----- > > From: Daniel Vetter <daniel@ffwll.ch> > > Sent: Wednesday, March 29, 2023 2:31 AM > > To: Inki Dae <inki.dae@samsung.com> > > Cc: airlied@linux.ie; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; > > linux-samsung-soc@vger.kernel.org > > Subject: Re: [GIT PULL] exynos-drm-next > > > > On Tue, Mar 28, 2023 at 01:05:24PM +0900, Inki Dae wrote: > > > Hi Dave and Daniel, > > > > > > Just one patch series that moves the existing Exynos DSI driver > > > to drm/bridge directory to support both SoCs family - Exynos > > > and I.MX - because same Exynos MIPI DSI ip can be used by the two > > > different SoC family. > > > > > > Of course, there are some concerns about this patch series because > > Exynos > > > and I.MX SoCs have different HW characteristic but use the same HW > > driver. > > > However, I believe that there should be no problem as Exynos and I.MX > > > developers have conducted tests and reviews enough for about a year > > > since last April. > > > > > > This would be the first case that we allow different vendor SoCs to use > > > same device driver at least in DRM world so we anticipate experiencing > > > and resolving new issues through ongoing maintenance, and ultimately, > > > the experiences gained here will undoubtedly be able to contribute > > > the development of the community as well. > > > > > > Please kindly let me know if there is any problem. > > > > > > Thanks, > > > Inki Dae Could you kindly help me understand if there are any missed steps on my part? I applied for commit access to the drm and drm-misc repositories through the link provided below two weeks ago, but haven't received any updates on my request. https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/569 Thanks, Inki Dae > > > > > > The following changes since commit > > 46f28427f6f824b6cff06fa025a55350b7de454a: > > > > > > Merge tag 'drm-rcar-next-20230325' of > > git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux into drm-next > > (2023-03-27 18:20:20 +0200) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos > > tags/exynos-drm-next-for-v6.4 > > > > Merged, but usually all drm bridge stuff goes through drm-misc, least so > > that there's some amount of collaboration and not so much inter-tree > > syncing. > > > > Please apply for drm-misc commit rights (at least a quick check shows no > > one from samsung) and land future bridge patches through that tree. > > > > Cheers, Daniel > > I will apply for drm-misc commit rights. :) > > Thanks, > Inki Dae > > > > > > > > > for you to fetch changes up to b2cfec52feb3bb737c4b65018ef4bfe9789e4be8: > > > > > > drm: bridge: samsung-dsim: Add i.MX8M Plus support (2023-03-28 09:05:41 > > +0900) > > > > > > ---------------------------------------------------------------- > > > A patch series for moving MIPI-DSI driver for Exynos DRM to drm/bridge > > > directory so that I.MX SoC family can also share the same device driver. > > > Samsung MIPI DSIM device is a common IP that can be used by Exynos and > > I.MX8M > > > Mini/Nano/Plus SoC. Regarding this, this patch series has added several > > > things below to existing MIPI DSI driver, > > > - Add exynos_dsi_type enum type to provide controller data from > > different > > > platforms. > > > - Add two pipeline detection ways support - existing Exynos DSI child > > node > > > and I.MX family of-graph port or ports. > > > - Consider component and bridged based DRM drivers. > > > - Add device tree binding support of I.MX family. > > > > > > ---------------------------------------------------------------- > > > Jagan Teki (14): > > > drm: exynos: dsi: Drop explicit call to bridge detach > > > drm: exynos: dsi: Lookup OF-graph or Child node devices > > > drm: exynos: dsi: Mark PHY as optional > > > drm: exynos: dsi: Add platform PLL_P (PMS_P) offset > > > drm: exynos: dsi: Introduce hw_type platform data > > > drm: exynos: dsi: Add atomic check > > > drm: exynos: dsi: Add input_bus_flags > > > drm: exynos: dsi: Add atomic_get_input_bus_fmts > > > drm: exynos: dsi: Consolidate component and bridge > > > drm: exynos: dsi: Add host helper for te_irq_handler > > > drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge > > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support > > > drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support > > > dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support > > > > > > Marek Szyprowski (1): > > > drm: exynos: dsi: Handle proper host initialization > > > > > > Marek Vasut (1): > > > drm: bridge: samsung-dsim: Add i.MX8M Plus support > > > > > > .../bindings/display/exynos/exynos_dsim.txt | 2 + > > > MAINTAINERS | 9 + > > > drivers/gpu/drm/bridge/Kconfig | 12 + > > > drivers/gpu/drm/bridge/Makefile | 1 + > > > drivers/gpu/drm/bridge/samsung-dsim.c | 1967 > > ++++++++++++++++++++ > > > drivers/gpu/drm/exynos/Kconfig | 1 + > > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1813 +---------------- > - > > > include/drm/bridge/samsung-dsim.h | 115 ++ > > > 8 files changed, 2191 insertions(+), 1729 deletions(-) > > > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > > > create mode 100644 include/drm/bridge/samsung-dsim.h > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > https://protect2.fireeye.com/v1/url?k=7fdd2b55-1e563e63-7fdca01a- > > 74fe485cbff1-6c2178cc05019313&q=1&e=e4f34328-cc9e-48f9-80e0- > > ec8c0c4246f2&u=http%3A%2F%2Fblog.ffwll.ch%2F >