| Message ID | 1461834713-24554-1-git-send-email-punit.agrawal@arm.com |
|---|---|
| State | New |
| Headers | show |
Thanks, applied. (For reference, the breakage hit is in BaseTools, which is known to have completely broken makefile dependencies.) On Thu, Apr 28, 2016 at 10:11:53AM +0100, Punit Agrawal wrote: > Parts of edk2 build process are a bit temperamental and may not be happy > with cleverness via user MAKEFLAGS modifications. > > To save unnecessary debugging of build breakage unset MAKEFLAGS. > > Suggested-by: Leif Lindholm <leif.lindholm@linaro.org> > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com> > --- > Hi, > > This issue bit me as I had MAKEFLAGS set to "-j 15" in my environment > to speed up builds. It broke the serial part of the edk2 build. > > Please merge if appropriate. > > Thanks, > Punit > > > uefi-build.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/uefi-build.sh b/uefi-build.sh > index 578bba8..49f2230 100755 > --- a/uefi-build.sh > +++ b/uefi-build.sh > @@ -9,7 +9,7 @@ > # No need to edit below unless you are changing script functionality. > # > > -unset WORKSPACE EDK_TOOLS_DIR > +unset WORKSPACE EDK_TOOLS_DIR MAKEFLAGS > > TOOLS_DIR="`dirname $0`" > . "$TOOLS_DIR"/common-functions > -- > 2.8.0.rc3 >
diff --git a/uefi-build.sh b/uefi-build.sh index 578bba8..49f2230 100755 --- a/uefi-build.sh +++ b/uefi-build.sh @@ -9,7 +9,7 @@ # No need to edit below unless you are changing script functionality. # -unset WORKSPACE EDK_TOOLS_DIR +unset WORKSPACE EDK_TOOLS_DIR MAKEFLAGS TOOLS_DIR="`dirname $0`" . "$TOOLS_DIR"/common-functions
Parts of edk2 build process are a bit temperamental and may not be happy with cleverness via user MAKEFLAGS modifications. To save unnecessary debugging of build breakage unset MAKEFLAGS. Suggested-by: Leif Lindholm <leif.lindholm@linaro.org> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com> --- Hi, This issue bit me as I had MAKEFLAGS set to "-j 15" in my environment to speed up builds. It broke the serial part of the edk2 build. Please merge if appropriate. Thanks, Punit uefi-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)