| Message ID | 20230410205803.45853-7-stefan.wahren@i2se.com |
|---|---|
| State | Accepted |
| Commit | ac0d46d5e38b3d380f742181ee879561ce6bd2f1 |
| Headers | show |
| Series | ARM: dts: imx6ull: Fix dtbs_check warnings | expand |
On 10/04/2023 22:58, Stefan Wahren wrote: > According to fsl,imx-gpc.yaml the General Power Control requires > a ipg clock and a Power Gating Control node. So add them to fix > the dtbs_check warnings on i.MX6UL boards: > > gpc@20dc000: 'clocks' is a required property > gpc@20dc000: 'clock-names' is a required property > gpc@20dc000: 'pgc' is a required property > > Suggested-by: Jacky Bai <ping.bai@nxp.com> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm/boot/dts/imx6ul.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi > index 118764c50d92..a8efaed69214 100644 > --- a/arch/arm/boot/dts/imx6ul.dtsi > +++ b/arch/arm/boot/dts/imx6ul.dtsi > @@ -719,6 +719,18 @@ gpc: gpc@20dc000 { > #interrupt-cells = <3>; > interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; > interrupt-parent = <&intc>; > + clocks = <&clks IMX6UL_CLK_IPG>; > + clock-names = "ipg"; > + > + pgc { > + #address-cells = <1>; > + #size-cells = <0>; Wrong indentation. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index 118764c50d92..a8efaed69214 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul.dtsi @@ -719,6 +719,18 @@ gpc: gpc@20dc000 { #interrupt-cells = <3>; interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&intc>; + clocks = <&clks IMX6UL_CLK_IPG>; + clock-names = "ipg"; + + pgc { + #address-cells = <1>; + #size-cells = <0>; + + power-domain@0 { + reg = <0>; + #power-domain-cells = <0>; + }; + }; }; iomuxc: pinctrl@20e0000 {
According to fsl,imx-gpc.yaml the General Power Control requires a ipg clock and a Power Gating Control node. So add them to fix the dtbs_check warnings on i.MX6UL boards: gpc@20dc000: 'clocks' is a required property gpc@20dc000: 'clock-names' is a required property gpc@20dc000: 'pgc' is a required property Suggested-by: Jacky Bai <ping.bai@nxp.com> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/boot/dts/imx6ul.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)