diff mbox

[edk2] BaseTools AARCH64/ARM: remove -save-temps GCC option

Message ID DB5PR08MB0918C1EFF7CC4CD6F88317B98B710@DB5PR08MB0918.eurprd08.prod.outlook.com
State New
Headers show

Commit Message

Evan Lloyd May 10, 2016, 3:18 p.m. UTC 
Hi Ard.
This is not a major inconvenience, but we do occasionally find the -save-temps flag vital when debugging.
What does seem strange is using GCC_ARM_CC_FLAGS, etc for a CLANG compiler.
Surely there ought to be CLANG_*_CC_FLAGS (which could be played with to your hearts content, without disrupting other compilers).

Regards,
Evan

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel

Sent: 10 May 2016 14:56
To: edk2-devel@lists.01.org; leif.lindholm@linaro.org
Cc: Ard Biesheuvel
Subject: [edk2] [PATCH] BaseTools AARCH64/ARM: remove -save-temps GCC option

Recent CLANG version choke on the -save-temps options. Of course, this is not GCC's fault, but since it seems we don't need this option, just remove it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 BaseTools/Conf/tools_def.template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel May 10, 2016, 3:53 p.m. UTC | #1 
On 10 May 2016 at 17:18, Evan Lloyd <Evan.Lloyd@arm.com> wrote:
> Hi Ard.

> This is not a major inconvenience, but we do occasionally find the -save-temps flag vital when debugging.

> What does seem strange is using GCC_ARM_CC_FLAGS, etc for a CLANG compiler.


Since Clang is mostly GCC compatible in terms of command line options,
the ARM and AARCH64 CLANG35 toolchain tag is part of the GCC toolchain
family. That by itself is not a reason to have completely separate CC
flag definitions, though. I just never thought about it.

> Surely there ought to be CLANG_*_CC_FLAGS (which could be played with to your hearts content, without disrupting other compilers).

>


Indeed. Will go that route instead.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index 2065fa34998f..616a27871978 100644
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -4323,8 +4323,8 @@  DEFINE GCC_ALL_CC_FLAGS            = -g -Os -fshort-wchar -fno-strict-aliasing -
 DEFINE GCC_IA32_CC_FLAGS           = DEF(GCC_ALL_CC_FLAGS) -m32 -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-probe
 DEFINE GCC_X64_CC_FLAGS            = DEF(GCC_ALL_CC_FLAGS) -mno-red-zone -Wno-address -mno-stack-arg-probe
 DEFINE GCC_IPF_CC_FLAGS            = DEF(GCC_ALL_CC_FLAGS) -minline-int-divide-min-latency
-DEFINE GCC_ARM_CC_FLAGS            = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -save-temps -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft
-DEFINE GCC_AARCH64_CC_FLAGS        = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -save-temps -fverbose-asm -funsigned-char  -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -fno-asynchronous-unwind-tables
+DEFINE GCC_ARM_CC_FLAGS            = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft
+DEFINE GCC_AARCH64_CC_FLAGS        = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char  -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -fno-asynchronous-unwind-tables
 DEFINE GCC_AARCH64_CC_XIPFLAGS     = -mstrict-align
 DEFINE GCC_DLINK_FLAGS_COMMON      = -nostdlib --pie
 DEFINE GCC_DLINK2_FLAGS_COMMON     = --script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds